Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module sources should be transparent to auditors #2117

Open
kriskowal opened this issue Mar 6, 2024 · 0 comments
Open

Module sources should be transparent to auditors #2117

kriskowal opened this issue Mar 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request project Issues submitted for attention of project management at Agoric to communicate with stake-holders

Comments

@kriskowal
Copy link
Member

kriskowal commented Mar 6, 2024

What is the Problem Being Solved?

Auditors should inspect code artifacts that are actually evaluated, not compiled artifacts. Bundles do not currently contain the source code the auditor will find in the contract’s Github repository, but rather the combined result of a ses-censoriship-evasive-transform (@endo/evasive-transform) and the module-to-ses-script-transform (@endo/static-module-record) which collectively attempt to preserve line numbers and spacing, but fails on both counts to varying degrees. Source maps should not be used to make the generated code resemble the alleged original sources because source maps can be used for malicious distortions that hide attack code. Auditing has different design criteria than debugging #2116.

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Compatibility Considerations

Upgrade Considerations

@kriskowal kriskowal added the enhancement New feature or request label Mar 6, 2024
@kriskowal kriskowal added the project Issues submitted for attention of project management at Agoric to communicate with stake-holders label Mar 6, 2024
@kriskowal kriskowal self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project Issues submitted for attention of project management at Agoric to communicate with stake-holders
Projects
None yet
Development

No branches or pull requests

1 participant