Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compartment-mapper): Collect unused module descriptors #2313

Closed
kriskowal opened this issue Jun 10, 2024 · 0 comments · Fixed by #2614
Closed

feat(compartment-mapper): Collect unused module descriptors #2313

kriskowal opened this issue Jun 10, 2024 · 0 comments · Fixed by #2614
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kriskowal
Copy link
Member

What is the Problem Being Solved?

When building an archive, the compartment mapper currently collects unused compartment descriptors, but the increased prevalence of package exports has created a lot of unused module descriptors.

Description of the Design

We should mark and sweep these too, as we do with the compartment “retained” flag.

Security Considerations

None.

Scaling Considerations

Should reduce bundle size.

Test Plan

Compatibility Considerations

May frustrate hashes of existing applications when they upgrade bundle-source in their package lock. I hope we no longer support system-level agoric CLI since upgrading that will frustrate hashes without opt-in.

Upgrade Considerations

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant