You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Compartment Mapper has a single, large integration test that shakes out some of the low hanging interoperability issues between CommonJS and ESM, especially at the packaging level, but is wholly inadequate for isolating unit test cases and covering all of the edge conditions. The benefit of the integration test as-is is that it covers all of the workflows through the compartment mapper including direct execution off disk and various workflows that pass through an archive. We should create a scaffold that runs all of these workflows for individual unit test cases.
The Compartment Mapper has a single, large integration test that shakes out some of the low hanging interoperability issues between CommonJS and ESM, especially at the packaging level, but is wholly inadequate for isolating unit test cases and covering all of the edge conditions. The benefit of the integration test as-is is that it covers all of the workflows through the compartment mapper including direct execution off disk and various workflows that pass through an archive. We should create a scaffold that runs all of these workflows for individual unit test cases.
The tests in LavaMoat https://github.com/LavaMoat/LavaMoat/tree/main/packages/core/test/scenarios cover a number of oddities for CommonJS linkage. They utilize a scaffold—having a similar scaffold would reduce the cost of adding tests.
Also, an exhaustive set of tests from esbuild would give us considerably more coverage evanw/esbuild#1591 (comment)
The text was updated successfully, but these errors were encountered: