Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No comma replacement in Bill type section #44

Closed
ndi123 opened this issue Apr 2, 2021 · 9 comments
Closed

No comma replacement in Bill type section #44

ndi123 opened this issue Apr 2, 2021 · 9 comments

Comments

@ndi123
Copy link

ndi123 commented Apr 2, 2021

When entering personal amount in the bill type section there is no comma replacement to a point. In the regular section there is a replacement from comma to a point. The missing replacement results in wrong results because everything after the comma will be ignored.

Example:

grafik

grafik

julien-nc pushed a commit that referenced this issue Apr 3, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Thanks for the bug report. It should be fixed now in v1.3.1-1-nightly which was released. Could you give it a try?

This issue was also affecting custom owed amounts. I thought it was alright because comas were replaced when evaluating a formula but not when just writing a simple number with a coma 😁. So 2,2 + 1 was alright but 2,2 was not. It's now ok.

@ndi123
Copy link
Author

ndi123 commented Apr 4, 2021

Thank you for the quick fix. It's working now when using commas 😃 There ist one cosmetic thing: When entering amount in main section comma will immediately replaced with point (but only when entering a number with comma - when using simple math only the first number with comma will be replaced). This replacement is not happening in custom owed amount.

One stupid question: Why 2.4+1.2 will be displayed as 3.5999999999999996?

julien-nc pushed a commit that referenced this issue Apr 5, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc pushed a commit that referenced this issue Apr 5, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Thanks for your precise remarks. I think everything is fixed in latest nightly.

Strange javascript decimals is now ok and comas are replaced on each new character when typing main amount.

Could you try it?

@ndi123
Copy link
Author

ndi123 commented Apr 7, 2021

Strange decimals are fixed and comma replacement ist working in main amount 👍 To have a consistent behaviour comma replacement in personal amount would also make sense in my opinion.

julien-nc pushed a commit that referenced this issue Apr 9, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

You're right, thanks for the feedback and the remarks.

Next release is coming soon.

@ndi123
Copy link
Author

ndi123 commented Apr 11, 2021

I have now noticed another problem: When I enter a two-digit number followed by a comma/point then the point will be deleted when ich try to enter the first number after the comma.

GIF 11 04 2021 23-02-27

julien-nc pushed a commit that referenced this issue Apr 12, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

This should be fixed in v1.3.1-6-nightly. Could you try it?

@ndi123
Copy link
Author

ndi123 commented Apr 12, 2021

It's fixed 👍

@julien-nc
Copy link
Owner

Yay! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants