Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Statistics enhancement - Spent per member per month #58

Closed
Raspikabek opened this issue Jun 24, 2021 · 4 comments
Closed

[Request] Statistics enhancement - Spent per member per month #58

Raspikabek opened this issue Jun 24, 2021 · 4 comments
Labels
enhancement New feature or request testing

Comments

@Raspikabek
Copy link

Request for the addition of a new table + graph of a Spends per member per month in the Monthly stats per member existing section

This will bring a bit more value to determine who spends more or less regardless who has paid for it. Existing Global Stats already displays the total sum of this per member, however this is not reported in a monthly basis in in details below.

Thanks!

PS: amazing job! I fell in love with this app! Keep going the good work!

julien-nc pushed a commit that referenced this issue Jun 25, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc
Copy link
Owner

Thanks for the suggestion and for the love!

I like the idea and it was quite quick to implement.
It's available in latest nightly build. Small problem if you want to try it (which would be great): Cospend is now only compatible with Nextcloud >= 22. So you can install this nightly on Nextcloud 22RC1 which is available in https://download.nextcloud.com/server/prereleases/

There has been some changes in the line chart style, datasets are not stacked anymore and colored areas are not drawn anymore. Those line charts are more classic (and readable) now. I'm interested to know what you think about those changes if you get to try the nightly.
Cheers

@julien-nc julien-nc added testing enhancement New feature or request labels Jun 25, 2021
@Raspikabek
Copy link
Author

Astounding! Thanks for the quick reply. I tried myself by forking the project and I saw the Statistics part is a bit 'hard-coded' and started myself to see how could I create a PR for this, didn't have time to fully understand the structure of the 'stats' variable and its content though.

Anyway, thanks!

I'm running Nextcloud with linuxserver/nextcloud image, right now in version 21.X if I find some time I'll try to setup another test environment for this, otherwise I'll have to wait till v22 is fully released.

Again, thanks a million!

@julien-nc
Copy link
Owner

Feel free to reopen if this feature does not properly work.

@Raspikabek
Copy link
Author

I updated the latest version a while ago, finally got a chance to take a look into this and I've to say: BIG THANKS! It works flawlessly and now makes tons of sense.

Thanks for hear me out and implementing this new feature request. You are a gent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

2 participants