Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): Replace testbackend with the new origin-backend #137

Merged
merged 21 commits into from
Oct 25, 2019
Merged

feat(backend): Replace testbackend with the new origin-backend #137

merged 21 commits into from
Oct 25, 2019

Conversation

josipbagaric
Copy link
Contributor

@josipbagaric josipbagaric commented Oct 14, 2019 •
edited
Loading

Replaced utils-testbackend with a new origin-backend.

Features:

  • New ORM structure with the following entities:
    • MarketContractLookup - contains a reference to all the Market contracts deployed
    • AnyEntity - serves as a multi-functional key-value store-it-all entity
  • Use of TypeORM for easier adaptation to different databases
  • Store test databases in SQLite instead of a JSON file
  • Add an API versioning scheme: HOST/api (latest API version) and HOST/api/v1 point to the same API for now, but it's extendable in the future
  • Separate each route to a separate file and use a router to handle routes
  • Better code structure and quality

@josipbagaric
feat(backend): Replace testbackend with the new origin-backend
20e1daf
@josipbagaric
chore(monorepo): replace utils-testbackend references with origin-bac…
298fd46 
…kend
@josipbagaric
chore(monorepo): make libs use POST instead of PUT for creating insta…
cb61128 
…nces
@josipbagaric
chore(monorepo): replace all references to db.json with db.sqlite
97723a8
@josipbagaric
chore(monorepo): adjust off chain properties saving to the new backend
ebfd19c
@josipbagaric
chore(monorepo): proper naming for MarketContractLookup
2c4ced3
@josipbagaric
Merge branch 'master' of github.com:energywebfoundation/origin
71496e2
@josipbagaric
Merge branch 'master' into origin-backend
7aa8ba2
@josipbagaric
fix(event-listener): remove double-posting MarketContractLookup to th…
ff46dbf 
…e backend
@josipbagaric
chore(origin-backend): reorganize the folders and files in a more rea…
de2abd7 
…dable manner
@josipbagaric
feat(origin-backend): introduce API versioning
ee9fc1b
@josipbagaric
fix(event-listener): use correct API url
a2f492b
@josipbagaric
Merge branch 'master' into origin-backend
416a47f
@kosecki123
Copy link
Contributor

Since we reworking the backend I would like us to create origin-backend-client which consists of the code that will communicate with the API as a service as well as mock object that can be used for testing. This enables us to:

  • get rid of direct calling API
  • remove backend dependencies from the projects in favour of origin-backend-client
  • faster testing

@josipbagaric josipbagaric marked this pull request as ready for review October 24, 2019 09:32
@energywebfoundation energywebfoundation deleted a comment from e00dan Oct 24, 2019
kosecki123
kosecki123 reviewed Oct 25, 2019
View reviewed changes
packages/origin-backend/src/entity/AnyEntity.ts Outdated

@Entity()
@Unique(['type', 'contractAddress', 'identifier'])
export class AnyEntity extends BaseEntity {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not naming it Entity?

@josipbagaric josipbagaric merged commit c428e7d into master Oct 25, 2019
@josipbagaric josipbagaric deleted the origin-backend branch October 25, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosecki123 kosecki123 kosecki123 left review comments

@e00dan e00dan e00dan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josipbagaric @kosecki123 @e00dan