Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepEqual validation is buggy #47

Closed
VikalpP opened this issue Sep 23, 2021 · 0 comments · Fixed by #48 or highlighter-inc/react-native-hold-menu#1
Closed

deepEqual validation is buggy #47

VikalpP opened this issue Sep 23, 2021 · 0 comments · Fixed by #48 or highlighter-inc/react-native-hold-menu#1
Labels
bug Something isn't working

Comments

@VikalpP
Copy link
Contributor

VikalpP commented Sep 23, 2021

Describe the bug
deepEqual validation returns true for the below params.

const senderMenuItems = [ {text: 'Send', icon: 'trash'} ]
const receiverMenuItems = [ {text: 'Receiver', icon: 'trash'} ]
deepEqual(senderMenuItems, receiverMenuItems)

To Reproduce
Steps to reproduce the behavior:

  1. Try calling deepEqual with above given example

Expected behavior
It should return false.

Actual behavior
It's returning true.

Screenshots
None

Package versions

  • React: *
  • React Native: *
  • React Native Reanimated: *
  • React Native Hold Menu: 0.1.1
  • Expo: *
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant