Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image and binaries #2

Open
flaccid opened this issue Jul 13, 2017 · 4 comments
Open

Docker image and binaries #2

flaccid opened this issue Jul 13, 2017 · 4 comments

Comments

@flaccid
Copy link

flaccid commented Jul 13, 2017

Firstly, thank you very much for this. Very useful to us.

I've created https://github.com/flaccid/docker-redis-sentinel-proxy and pushed to GitHub. I was wondering how much I could contrib back to your repo, e.g. a Dockerfile, Makefile, image on Docker Hub etc.?

One thing for consideration is that automated builds in Docker Hub require building of things like binaries from within the docker image. Not sure how we'd do a COPY of a pre-built binary - I think the same situation as docker/hub-feedback#524.

Anyway, let me know your thoughts!

@enriclluelles
Copy link
Owner

hey there @flaccid didn't see this until know. Contribute whatever you want of course, and thanks for the Docker image.
About the build automation, I'll think about it, maybe add precompiled binaries

@devlounge
Copy link

Any update on this ?

@flaccid
Copy link
Author

flaccid commented Feb 6, 2018

Its been quite a while, but now these days the right solution to this is to use https://docs.docker.com/develop/develop-images/multistage-build/.

@patrickdk77
Copy link

You can check my repo, it's doing automated builds for all archs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants