Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to commander interface #7

Open
enriquecaballero opened this issue May 17, 2017 · 2 comments
Open

Add version number to commander interface #7

enriquecaballero opened this issue May 17, 2017 · 2 comments
Labels

Comments

@enriquecaballero
Copy link
Owner

After moving to semantic-release, we can no longer parse out the version number from package.json. We'll have to come up with a way of injecting the current version number during the build process.

@enriquecaballero
Copy link
Owner Author

enriquecaballero commented May 17, 2017

A few brainstorm notes:
Once unit testing is added in, Travis should run yarn test as its default script. Followed by after_success, yarn semantic-release will run as normal -- we'll just add a prepublish script to build the lib directory that will be published to npm prior to semantic-release's npm publish step. During this prepublish step, we inject the version number from package.json (the one semantic-release wrote in during the pre step) to define the correct --version argv within commander.

@enriquecaballero
Copy link
Owner Author

enriquecaballero commented May 24, 2017

@enriquecaballero enriquecaballero changed the title Add version number to commander Add version number to commander interface May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant