Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 候補WindowのNSWindowによる独自実装 #35

Merged
merged 35 commits into from
Aug 5, 2024
Merged

Conversation

nyanko3141592
Copy link
Collaborator

No description provided.

@nyanko3141592 nyanko3141592 self-assigned this Aug 5, 2024
Copy link
Collaborator Author

@nyanko3141592 nyanko3141592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要な変更

azooKeyMac.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
azooKeyMac.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@nyanko3141592 nyanko3141592 changed the title Feature/window 候補WIndowのNSWindowによる実装 Aug 5, 2024
@ensan-hcl ensan-hcl changed the title 候補WIndowのNSWindowによる実装 候補WindowのNSWindowによる実装 Aug 5, 2024
@ensan-hcl ensan-hcl changed the title 候補WindowのNSWindowによる実装 feat: 候補WindowのNSWindowによる独自実装 Aug 5, 2024
@ensan-hcl ensan-hcl linked an issue Aug 5, 2024 that may be closed by this pull request
@ensan-hcl ensan-hcl self-requested a review August 5, 2024 13:49
Copy link
Owner

@ensan-hcl ensan-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず処理の具体的な内容というよりはコードの体裁の部分のレビューをしました

azooKeyMac/InputController/Actions/ClientAction.swift Outdated Show resolved Hide resolved
azooKeyMac/InputController/Actions/UserAction.swift Outdated Show resolved Hide resolved
azooKeyMac/InputController/CandidateView.swift Outdated Show resolved Hide resolved
azooKeyMac/InputController/InputState.swift Outdated Show resolved Hide resolved
azooKeyMac/InputController/azooKeyMacInputController.swift Outdated Show resolved Hide resolved
@ensan-hcl ensan-hcl self-requested a review August 5, 2024 14:48
Copy link
Owner

@ensan-hcl ensan-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(細かいバグは別のPRで直していこう)

@ensan-hcl ensan-hcl merged commit 6f459d7 into main Aug 5, 2024
@ensan-hcl ensan-hcl deleted the feature/window branch August 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 候補ウィンドウを自前で準備する
2 participants