番号付きの候補リスト幅を少し広くする #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diskshima
commented
Sep 29, 2024
| @@ -145,7 +145,7 @@ class CandidatesViewController: NSViewController { | |||
| // ウィンドウの幅を設定（番号とパディングのための追加幅を考慮） | |||
| // 20 = corner radius * 2 | |||
| let windowWidth = if self.showCandidateIndex { | |||
| maxWidth + 32 | |||
| maxWidth + 48 | |||
There was a problem hiding this comment.
変更しておいて、なのですが、数行上で利用しているフォントサイズ16を基に計算するべきな気がしますので、その方が良さそうであれば、ご指摘ください！修正します。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
候補リストのデフォルト幅が少し狭いようだったので広くしました。
macOSの設定次第の可能性もありますので、指摘ください。
（なお、Discordのスクリーンショットでは同様に狭くなっている方もいる ようです）
Before
After