Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the desired behaviour for Database backends on Nothing * Nothing #11751

Closed
radeusgd opened this issue Dec 3, 2024 · 5 comments
Closed
Assignees

Comments

@radeusgd
Copy link
Member

radeusgd commented Dec 3, 2024

Currently, e.g. on Postgres an expression Nothing * Nothing results in operator is not unique: unknown * unknown.

The created SQL is correct (NULL * NULL) but the database does not like unknown types.

Do we:

  1. keep it as is, as it's a DB specific behaviour?
  2. try to glue it to avoid errors - replace the operation in SQL with NULL constant?

I guess (2) will be more user-friendly and consistent with in-memory backend.

@GregoryTravis
Copy link
Contributor

How do the other DBs handle this?

@radeusgd
Copy link
Member Author

radeusgd commented Dec 4, 2024

How do the other DBs handle this?

Snowflake and SQLServer both seem to accept the operation and simply return NULL.

So it seems that the issue may only be with Postgres.

@radeusgd
Copy link
Member Author

radeusgd commented Dec 4, 2024

Before this can be implemented we need to address #11757

@radeusgd radeusgd moved this from ❓New to 📤 Backlog in Issues Board Dec 18, 2024
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 20, 2025
@radeusgd
Copy link
Member Author

Since in #11757 we decided that Null columns won't be required in DB backends, so this issue is no longer relevant.

@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jan 22, 2025
@radeusgd
Copy link
Member Author

Updated tests are merged into the #11737 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟢 Accepted
Development

No branches or pull requests

2 participants