Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate frontend performance #5603

Closed
kazcw opened this issue Feb 9, 2023 · 4 comments
Closed

Investigate frontend performance #5603

kazcw opened this issue Feb 9, 2023 · 4 comments
Assignees
Milestone

Comments

@kazcw
Copy link
Contributor

kazcw commented Feb 9, 2023

Profile these objectives:

  • Startup
  • Opening the Component Browser
  • Opening a drop-down

Identify areas for performance improvement.

@kazcw kazcw self-assigned this Feb 9, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 9, 2023
@kazcw kazcw moved this from ❓New to 📤 Backlog in Issues Board Feb 9, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Feb 10, 2023
@jdunkerley
Copy link
Member

This purely on the IDE side - Jaroslav has done work on the project manager side already.

@kazcw kazcw changed the title Investigate performance Investigate frontend performance Feb 10, 2023
@enso-bot enso-bot bot mentioned this issue Feb 14, 2023
4 tasks
@kazcw
Copy link
Contributor Author

kazcw commented Feb 15, 2023

Findings

Startup:

Opening a dropdown (6 short lines):

Opening component browser:

  • Time taken: 1.7s
  • Most time spent in redraw_line.
  • No other obvious room for improvement; many small costs that add up. FRP overhead may be a significant contributor.

@enso-bot
Copy link

enso-bot bot commented Feb 15, 2023

Keziah Wesley reports a new STANDUP for today (2023-02-15):

Progress: Profiled the frontend. It should be finished by 2023-02-15.

Next Day: Next day I will be working on the #5669 task. Investigate performance of text rendering, as it's the most likely area for big frontend optimizations.

@kazcw kazcw closed this as completed Feb 16, 2023
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Feb 16, 2023
@kazcw kazcw mentioned this issue Feb 17, 2023
4 tasks
@wdanilo
Copy link
Member

wdanilo commented Feb 18, 2023

@kazcw thanks again for such a clear breakdown of your findings, very helpful!

Few questions:

  1. I understand that the parsing is really JS problem and after moving to our new parser (when it will support docs parsing) this should be resolved, right?
  2. The redraw_lines case is interesting. I've written a comment about it in another issue. We need to investigate it further, as if this is connected to MSDF calls, we are probably doing something wrong there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants