-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Input Widget #8753
Labels
-gui
d-intermediate
Difficulty: some prior knowledge required
p-medium
Should be completed in the next few sprints
x-new-feature
Type: new feature request
Milestone
Comments
Open
Open
Refinement notes:
|
Probably we should settle on "how to store metadata in our codebase - maybe in AST nodes?" |
The metadata changes are tracked in: This task should be done after them. |
Closed
Added a section about proper AST repairing, to avoid issues discovered when numeric input widget accepted just any code. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-gui
d-intermediate
Difficulty: some prior knowledge required
p-medium
Should be completed in the next few sprints
x-new-feature
Type: new feature request
Ctrl/Cmd click on parameter (defined by WidgetArgument presence) should turn it to "Code Input" widget, where user may put any arbitrary Enso code.
After accepting, the widget should stay, i.e. it should not be "broken" into other widgets - for example, when user type
2 + 2
and accepts it, the widget displaying2 + 2
should stay instead of being turned into two numeric widgets with+
between them.The code-repair algorithm should be improved to handle some "breaking" code correctly:
(
should be automatically closed, because we cannot handle it by wrapping in()
[
should be handled with current tree-repair approach, because it should be limited by encircling()
.Otherwise, some code written in code input widget could break other widgets or the entire application
The text was updated successfully, but these errors were encountered: