Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wheel package of comtypes #229

Closed
nanonyme opened this issue Apr 24, 2021 · 8 comments
Closed

Create wheel package of comtypes #229

nanonyme opened this issue Apr 24, 2021 · 8 comments
Labels
drop_py2 dev based on supporting only Python3, see #392 enhancement New feature or request
Milestone

Comments

@nanonyme
Copy link

Split from #216

Currently new pip is forced to whenever installing this package to first locally create a wheel, then install it. We should be creating and publishing universal wheels. https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels

@vasily-v-ryabov vasily-v-ryabov added the enhancement New feature or request label Apr 26, 2021
@junkmd
Copy link
Collaborator

junkmd commented Sep 11, 2022

This is related to #228.

I am thinking be started working on this after Py3.11 first release.

Assumed first changes

comtypes/setup.py

Lines 7 to 11 in cc9a013

from distutils.core import Command
from distutils.command.install import install
from setuptools import setup
from distutils.command.build_py import build_py

from setuptools import Command, setup
from setuptools.command.install import install
from setuptools.command.build_py import build_py

@junkmd junkmd added this to the 1.3.0 milestone Dec 5, 2022
@junkmd
Copy link
Collaborator

junkmd commented Dec 5, 2022

It would be good to work on this issue at the time of dropping Python 2.7 from support.

(related to #392)

@junkmd junkmd added the drop_py2 dev based on supporting only Python3, see #392 label Dec 11, 2022
@junkmd
Copy link
Collaborator

junkmd commented Dec 11, 2022

NOTE: this is related to #394.

@vasily-v-ryabov
Copy link
Collaborator

Current releases (including 1.2.1, of course) have universal wheels already. Is this issue still relevant or should be closed?

@nanonyme
Copy link
Author

nanonyme commented Jan 4, 2024

You're right, this is done.

@nanonyme nanonyme closed this as completed Jan 4, 2024
@junkmd
Copy link
Collaborator

junkmd commented Jan 4, 2024

I recognize a package as a universal wheel available package if it has a .whl file in the Built Distribution section of https://pypi.org/project/NAME/#files.

https://pypi.org/project/comtypes/#files is satisfied the condition.

@nanonyme
Copy link
Author

nanonyme commented Jan 5, 2024

@junkmd it is not possible for projects with Python C extensions to have universal wheels. This includes pyyaml. That kind of projects have to build a per-platform wheel for all targets. Comtypes has no C extensions hence why it's possible here. Your definition for universal wheel is wrong.

@junkmd
Copy link
Collaborator

junkmd commented Jan 5, 2024

Thank you for bringing this to my attention.

I misunderstood the term of "universal wheels".
Upon your clarification, I checked and realized that the definition is documented at https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels

Having removed the part that I misunderstood, and what I essentially wanted to tell is "It is a wheel available package if it has one or more .whl files in the Built Distribution section of https://pypi.org/project/NAME/#files".

(I just mentioned pyyaml as an example of a package for which wheel is available.)

Thank you.

@junkmd junkmd modified the milestones: 1.3.0, 1.2.1 Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drop_py2 dev based on supporting only Python3, see #392 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants