Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Move asset compilation config to recommended location #100

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Conversation

orien
Copy link
Contributor

@orien orien commented Jun 11, 2021

Context

The Rails Engine Guide recommends to put asset compilation configuration in the engine.rb file:

initializer "blorgh.assets.precompile" do |app|
  app.config.assets.precompile += %w( admin.js admin.css )
end

https://guides.rubyonrails.org/v6.1/engines.html#separate-assets-and-precompiling

Change

  • Move the asset compilation configuration.
  • Prepare the release of 0.7.0

Copy link
Contributor

@petervandoros petervandoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 assuming you've tested the changes.

@orien
Copy link
Contributor Author

orien commented Jun 11, 2021

Everything looks good

@orien orien merged commit 1f58f71 into master Jun 11, 2021
@orien orien deleted the orien/assets branch June 11, 2021 02:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants