Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Specify supported rails versions #82

Merged
merged 7 commits into from
Dec 12, 2017
Merged

Conversation

zubin
Copy link
Contributor

@zubin zubin commented Dec 11, 2017

Context

Currently it's unclear which versions of rails are supported.

After installing this repo, the build failed mysteriously with:

NoMethodError:
  undefined method `configure' for #<TestApp::Application:0x00007ff52a0fab78>
  Did you mean?  config
# ./spec/test_app/config/environments/test.rb:1:in `<top (required)>'

This is because I had rails 4.0 installed, which satisfied the gem requirements but wasn't compatible with the test app.

Changes

  • Add appraisal gem for testing against multiple rails versions.
  • Update CI script to use appraisal.

Considerations

  • The gems are vendored into gemfiles. See here for rationale.
  • Only rails 4.2 is tested because the test app appears to be generated with that version.

@zubin zubin requested review from shevaun and removed request for shevaun December 11, 2017 01:42
Copy link

@shevaun shevaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@zubin
Copy link
Contributor Author

zubin commented Dec 12, 2017

@shevaun Added some commits in preparation for rails 5 support.

@shevaun
Copy link

shevaun commented Dec 12, 2017

LGTM

@zubin zubin merged commit e75a2e8 into master Dec 12, 2017
@orien orien deleted the specify-supported-rails-versions branch June 4, 2021 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants