Rails 5 support #83
Rails 5 support #83
Conversation
zubin
changed the base branch from
specify-supported-rails-versions
to
master
guide.gemspec
Outdated
| @@ -14,7 +14,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.files = Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.rdoc"] | |||
|
|
|||
| s.add_dependency "rails", ">= 3.1", "< 5" | |||
| s.add_dependency "rails", ">= 3.1" | |||
There was a problem hiding this comment.
do we want to add a < 6 clause here, to help us in the next upgrade? :)
| @@ -48,7 +48,11 @@ | |||
| end | |||
|
|
|||
| it "does not render the show template" do | |||
| expect(response).not_to render_template(:show) | |||
| if Rails.version < '5' | |||
There was a problem hiding this comment.
One idea is we make this version (0.4.0) only compatible with Rails 5, and projects on Rails 4 can continue to use 0.3.2. What do you think?
There was a problem hiding this comment.
@shevaun I like that idea, but the only downside is that we wouldn't be able to merge the Gemfile change into master (on Market).
Maybe minimum version should be 4 (since we're using around_action now).
There was a problem hiding this comment.
that's a good point. Yep I'm happy to make this version 4+ compatible!
| def get(action, params = {}) | ||
| super action, params: params | ||
| end | ||
| end |
There was a problem hiding this comment.
This is interesting. Might end up using this in the marketplace app instead of changing every controller spec! Although, I imagine we'll need to do the change at some point
| @@ -0,0 +1 @@ | |||
| /Users/zubin/src/envato/guide/spec/test_apps/shared/app/assets/javascripts/application.js | |||
There was a problem hiding this comment.
what are these files and why do they have your filepath in them?
There was a problem hiding this comment.
@shevaun These are symlinked from spec/test_apps/shared/app.
I intended to use relative symlinks but apparently did not.
Context
Currently the gem depends on rails < 5.
Changes