automated mechanism summary lists module whose evaluation failed

[xdelaruelle]

Even if one module evaluation part of an automated mechanism fails, it is reported in the list of modules loaded, unloaded or reloaded for the mechanism. This could be confusing as an error occurred for these modules.

This confusing report can be seen when force mode is enabled since if force mode is disabled, the whole process abort and no summary list for automated mechanisms is reported.

Taking the following modulefiles as example:

$ cat /path/to/modulefiles/ta
#%Module
$ cat /path/to/modulefiles/tb
#%Module
$ cat /path/to/modulefiles/tc
#%Module
prereq ta tb
if {[module-info mode load] && ![is-loaded ta]} {
    break
}
$ module load ta tb tc
$ module list
Currently Loaded Modulefiles:
 1) ta   2) tb   3) tc

Unloading ta triggers reload of tc which fails on its reload phase. However tc is reported in the Reloading dependent which makes people think that reload operation was ok.

$ module unload --auto --force ta
Unloading ta
  WARNING: Reload of dependent tc failed
  Reloading dependent: tc
$ module list
Currently Loaded Modulefiles:
 1) tb