diff --git a/.github/workflows/android_build.yml b/.github/workflows/android_build.yml index edfadb63c2..2c6fc1496d 100644 --- a/.github/workflows/android_build.yml +++ b/.github/workflows/android_build.yml @@ -71,7 +71,7 @@ jobs: run: ./ci/mac_start_emulator.sh # Return to using: # ./bazelw mobile-install --fat_apk_cpu=x86 --start_app //examples/java/hello_world:hello_envoy - # When https://github.com/lyft/envoy-mobile/issues/853 is fixed. + # When https://github.com/envoyproxy/envoy-mobile/issues/853 is fixed. - name: 'Start java app' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -114,7 +114,7 @@ jobs: run: ./ci/mac_start_emulator.sh # Return to using: # ./bazelw mobile-install --fat_apk_cpu=x86 --start_app //examples/kotlin/hello_world:hello_envoy_kt - # When https://github.com/lyft/envoy-mobile/issues/853 is fixed. + # When https://github.com/envoyproxy/envoy-mobile/issues/853 is fixed. - name: 'Start kotlin app' env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e09a32b178..c59fb03699 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -39,7 +39,7 @@ following guidelines for all code, APIs, and documentation: # Submitting a PR * Fork the repo. -* [[TODO: add bootstrap script for prepush hook](https://github.com/lyft/envoy-mobile/issues/185)] +* [[TODO: add bootstrap script for prepush hook](https://github.com/envoyproxy/envoy-mobile/issues/185)] * Create your PR. * Tests will automatically run for you. * We will **not** merge any PR that is not passing tests. diff --git a/EnvoyMobile.podspec b/EnvoyMobile.podspec index b4ca64e9f5..524ed9b6ba 100644 --- a/EnvoyMobile.podspec +++ b/EnvoyMobile.podspec @@ -11,7 +11,7 @@ Pod::Spec.new do |s| s.swift_versions = ['5.5'] s.libraries = 'resolv.9', 'c++' s.frameworks = 'Network', 'SystemConfiguration', 'UIKit' - s.source = { http: "https://github.com/lyft/envoy-mobile/releases/download/v#{s.version}/envoy_ios_cocoapods.zip" } + s.source = { http: "https://github.com/envoyproxy/envoy-mobile/releases/download/v#{s.version}/envoy_ios_cocoapods.zip" } s.vendored_frameworks = 'Envoy.framework' s.source_files = 'Envoy.framework/Headers/*.h', 'Envoy.framework/Swift/*.swift' end diff --git a/STYLE.md b/STYLE.md index 1914cde4b9..108560a335 100644 --- a/STYLE.md +++ b/STYLE.md @@ -42,4 +42,4 @@ to provide some enforced consistency, we've adopted the convention of defining t lowest applicable layer (core/bridge) of the library, and then declaring public `extern const` values defined in terms of the enumeration, to be shared across bridge and platform code. See, for example: -https://github.com/lyft/envoy-mobile/blob/2a1b53427100d94878551b55bb564e9117f83fe6/library/common/types/c_types.h#L25 +https://github.com/envoyproxy/envoy-mobile/blob/2a1b53427100d94878551b55bb564e9117f83fe6/library/common/types/c_types.h#L25 diff --git a/bazel/envoy_mobile_repositories.bzl b/bazel/envoy_mobile_repositories.bzl index 68ddd4d7db..b779dea9aa 100644 --- a/bazel/envoy_mobile_repositories.bzl +++ b/bazel/envoy_mobile_repositories.bzl @@ -27,7 +27,7 @@ def upstream_envoy_overrides(): urls = ["https://github.com/protocolbuffers/protobuf/releases/download/v3.16.0/protobuf-all-3.16.0.tar.gz"], ) - # Workaround old NDK version breakages https://github.com/lyft/envoy-mobile/issues/934 + # Workaround old NDK version breakages https://github.com/envoyproxy/envoy-mobile/issues/934 http_archive( name = "com_github_libevent_libevent", urls = ["https://github.com/libevent/libevent/archive/0d7d85c2083f7a4c9efe01c061486f332b576d28.tar.gz"], @@ -38,7 +38,7 @@ def upstream_envoy_overrides(): # Patch upstream Abseil to prevent Foundation dependency from leaking into Android builds. # Workaround for https://github.com/abseil/abseil-cpp/issues/326. - # TODO: Should be removed in https://github.com/lyft/envoy-mobile/issues/136 once rules_android + # TODO: Should be removed in https://github.com/envoyproxy/envoy-mobile/issues/136 once rules_android # supports platform toolchains. http_archive( name = "com_google_absl", diff --git a/bazel/pom_template.xml b/bazel/pom_template.xml index 82f04aca70..38ebb8da00 100644 --- a/bazel/pom_template.xml +++ b/bazel/pom_template.xml @@ -14,7 +14,7 @@ Envoy Mobile Client networking libraries based on the Envoy project. - https://github.com/lyft/envoy-mobile + https://github.com/envoyproxy/envoy-mobile @@ -46,9 +46,9 @@ - https://github.com/lyft/envoy-mobile - scm:git:git@github.com:lyft/envoy-mobile.git - scm:git:git@github.com:lyft/envoy-mobile.git + https://github.com/envoyproxy/envoy-mobile + scm:git:git@github.com:envoyproxy/envoy-mobile.git + scm:git:git@github.com:envoyproxy/envoy-mobile.git HEAD diff --git a/dist/BUILD b/dist/BUILD index 91f357b3c0..2657e4bc00 100644 --- a/dist/BUILD +++ b/dist/BUILD @@ -6,7 +6,7 @@ licenses(["notice"]) # Apache 2 # NOTE: You must first build the top-level targets //:ios_dist and //:android_dist to use the # artifacts referenced here. # You can also download the distributables referenced here from envoy-mobile's releases page: -# https://github.com/lyft/envoy-mobile/releases +# https://github.com/envoyproxy/envoy-mobile/releases aar_import( name = "envoy_mobile_android", diff --git a/docs/conf.py b/docs/conf.py index d7f8016e32..3e7e11cccd 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -69,9 +69,9 @@ def setup(app): # ones. extensions = ['sphinxcontrib.httpdomain', 'sphinx.ext.extlinks', 'sphinx.ext.ifconfig'] extlinks = { - 'issue': ('https://github.com/lyft/envoy-mobile/issues/%s', ''), - 'repo': ('https://github.com/lyft/envoy-mobile/blob/{}/%s'.format(blob_sha), ''), - 'tree': ('https://github.com/lyft/envoy-mobile/tree/%s', ''), + 'issue': ('https://github.com/envoyproxy/envoy-mobile/issues/%s', ''), + 'repo': ('https://github.com/envoyproxy/envoy-mobile/blob/{}/%s'.format(blob_sha), ''), + 'tree': ('https://github.com/envoyproxy/envoy-mobile/tree/%s', ''), } # Set up global substitutions diff --git a/docs/root/development/performance/binary_size.rst b/docs/root/development/performance/binary_size.rst index c509422d7d..c86d094a31 100644 --- a/docs/root/development/performance/binary_size.rst +++ b/docs/root/development/performance/binary_size.rst @@ -154,7 +154,7 @@ Open issues regarding size ``perf/size`` is a label tagging all current open issues that can improve binary size. Check out the issues `here -`_. After performing +`_. After performing any change that tries to address these issues you should run through the analysis pipeline described above, and make sure your changes match expectations. diff --git a/docs/root/development/performance/cpu_battery_impact.rst b/docs/root/development/performance/cpu_battery_impact.rst index 9989a9ed32..1822627002 100644 --- a/docs/root/development/performance/cpu_battery_impact.rst +++ b/docs/root/development/performance/cpu_battery_impact.rst @@ -116,4 +116,4 @@ Open issues ~~~~~~~~~~~ For current issues with CPU/battery, please see issues with the -`perf/cpu label `_. +`perf/cpu label `_. diff --git a/docs/root/development/performance/device_connectivity.rst b/docs/root/development/performance/device_connectivity.rst index 4875eb6370..3669eb4850 100644 --- a/docs/root/development/performance/device_connectivity.rst +++ b/docs/root/development/performance/device_connectivity.rst @@ -79,4 +79,4 @@ Open issues ~~~~~~~~~~~ For current issues with device conditions, please see issues with the -`perf/device label `_. +`perf/device label `_. diff --git a/docs/root/development/releasing/releasing.rst b/docs/root/development/releasing/releasing.rst index c02d99e13b..001f18ae34 100644 --- a/docs/root/development/releasing/releasing.rst +++ b/docs/root/development/releasing/releasing.rst @@ -4,7 +4,7 @@ Releasing ========= The following workflow should be followed to create and publish a new Envoy Mobile -`release `_. +`release `_. Prepare for release ------------------- @@ -19,7 +19,7 @@ Publish release and artifacts ----------------------------- After merging the above changes, a new release may be -`tagged `_. +`tagged `_. When tagging a release, it should contain all the artifacts built by CI on the main commit being tagged as the new version. These artifacts may be downloaded by clicking on the CI status of the diff --git a/docs/root/development/testing/local_stats.rst b/docs/root/development/testing/local_stats.rst index 5b26b7aa20..1b04c2f84c 100644 --- a/docs/root/development/testing/local_stats.rst +++ b/docs/root/development/testing/local_stats.rst @@ -3,7 +3,7 @@ Local Stats =========== -The `local-stats` `branch `_ allows a +The `local-stats` `branch `_ allows a developer to run a local statsd server, and see stats emissions from a client running in the simulator/emulator. Unless network tunneling is set up this is not going to work in a physical device, as the statsd server is running on the computer's local network. @@ -12,9 +12,9 @@ device, as the statsd server is running on the computer's local network. Config ------ -The `config template `_ +The `config template `_ has already been updated to use a local statsd server. However, if you are using Android to test, -the `static address `_ +the `static address `_ used for the server should be changed to ``10.0.2.2`` per the `Set up Android Emulator networking `_ docs. @@ -28,7 +28,7 @@ Steps node stats.js config.js - An example ``config.js`` file. Note that the port must match the port in the `config_template `_:: + An example ``config.js`` file. Note that the port must match the port in the `config_template `_:: { port: 8125 diff --git a/docs/root/development/tools/intellij.rst b/docs/root/development/tools/intellij.rst index 16ad06be76..00e73f527f 100644 --- a/docs/root/development/tools/intellij.rst +++ b/docs/root/development/tools/intellij.rst @@ -11,7 +11,7 @@ Using IntelliJ with Envoy Mobile To get started using IntelliJ with Envoy Mobile: 1. Download a supported `IntelliJ version `_ supported by the Bazel plugin -2. Apply local hacks to make IntelliJ work using the branch `hack-for-intellij `_ +2. Apply local hacks to make IntelliJ work using the branch `hack-for-intellij `_ 3. Open up the Envoy Mobile project using the Bazel import project wizard diff --git a/docs/root/intro/getting_help.rst b/docs/root/intro/getting_help.rst index aa73634a3e..5145eb2e47 100644 --- a/docs/root/intro/getting_help.rst +++ b/docs/root/intro/getting_help.rst @@ -6,4 +6,4 @@ Getting help We are very interested in building a community around Envoy Mobile. Please reach out to us if you are interested in using it and need help or want to contribute. -Please see `contact info `_. +Please see `contact info `_. diff --git a/docs/root/intro/version_history.rst b/docs/root/intro/version_history.rst index d646e121bf..cbb3de0d63 100644 --- a/docs/root/intro/version_history.rst +++ b/docs/root/intro/version_history.rst @@ -85,7 +85,7 @@ Extensibility: - Introduces platform filter interfaces and bridging (:issue:`#795 <795>`, :issue:`#840 <840>`, :issue:`#858 <858>`, :issue:`#913 <913>`, :issue:`#940 <940>`, :issue:`#955 <955>`, :issue:`#943 <943>`, :issue:`#962 <962>`) - Introduces Envoy's extension platform (:issue:`#860 <860>`) -Lastly, and perhaps most importantly, we have adopted a formal `inclusive language policy `_ +Lastly, and perhaps most importantly, we have adopted a formal `inclusive language policy `_ (:issue:`#948 <948>`) and updated all necessary locations (:issue:`#944 <944>`, :issue:`#945 <945>`, :issue:`#946 <946>`) 0.3.0 (Mar 26, 2020) diff --git a/docs/root/start/building/building.rst b/docs/root/start/building/building.rst index 2bf9d8faf1..734738ef7c 100644 --- a/docs/root/start/building/building.rst +++ b/docs/root/start/building/building.rst @@ -9,13 +9,13 @@ To get started, you can use `this quick start guide Ensure that the ``envoy`` **submodule** is initialized when cloning by using ``--recursive``: -``git clone https://github.com/lyft/envoy-mobile.git --recursive`` +``git clone https://github.com/envoyproxy/envoy-mobile.git --recursive`` If the repo was not initially cloned recursively, you can manually initialize the Envoy submodule: ``git submodule update --init`` -.. _releases: https://github.com/lyft/envoy-mobile/releases +.. _releases: https://github.com/envoyproxy/envoy-mobile/releases ------------------ Bazel requirements diff --git a/examples/objective-c/hello_world/ViewController.m b/examples/objective-c/hello_world/ViewController.m index 8c01f37304..1aa00768c3 100644 --- a/examples/objective-c/hello_world/ViewController.m +++ b/examples/objective-c/hello_world/ViewController.m @@ -104,7 +104,7 @@ - (void)performRequest { [weakSelf addResponseMessage:message headerMessage:headerMessage error:nil]; }]; [prototype setOnErrorWithClosure:^(EnvoyError *error, StreamIntel *ignored) { - // TODO: expose attemptCount. https://github.com/lyft/envoy-mobile/issues/823 + // TODO: expose attemptCount. https://github.com/envoyproxy/envoy-mobile/issues/823 NSString *message = [NSString stringWithFormat:@"failed within Envoy library %@", error.message]; NSLog(@"%@", message); diff --git a/library/common/api/external.cc b/library/common/api/external.cc index 9e78a90e40..18810fdd81 100644 --- a/library/common/api/external.cc +++ b/library/common/api/external.cc @@ -9,7 +9,7 @@ namespace Api { namespace External { // TODO(goaway): This needs to be updated not to leak once multiple engines are supported. -// See https://github.com/lyft/envoy-mobile/issues/332 +// See https://github.com/envoyproxy/envoy-mobile/issues/332 static absl::flat_hash_map registry_{}; // TODO(goaway): To expose this for general usage, it will need to be made thread-safe. For now it diff --git a/library/common/config/config.cc b/library/common/config/config.cc index 7ed22ad4bb..2e876f649d 100644 --- a/library/common/config/config.cc +++ b/library/common/config/config.cc @@ -252,7 +252,7 @@ const char* config_template = R"( // https://github.com/envoyproxy/envoy-mobile/issues/1534 R"( preresolve_hostnames: *dns_preresolve_hostnames -)" // TODO: Support IPV6 https://github.com/lyft/envoy-mobile/issues/1022 +)" // TODO: Support IPV6 https://github.com/envoyproxy/envoy-mobile/issues/1022 R"( dns_lookup_family: V4_PREFERRED )" // On mobile, backgrounding might cause the host to be past its TTL without good diff --git a/library/common/engine.cc b/library/common/engine.cc index 08cfa031ad..1e5981f7b6 100644 --- a/library/common/engine.cc +++ b/library/common/engine.cc @@ -17,12 +17,12 @@ Engine::Engine(envoy_engine_callbacks callbacks, envoy_logger logger, dispatcher_(std::make_unique()) { // Ensure static factory registration occurs on time. // TODO: ensure this is only called one time once multiple Engine objects can be allocated. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 ExtensionRegistry::registerFactories(); // TODO(Augustyniak): Capturing an address of event_tracker_ and registering it in the API // registry may lead to crashes at Engine shutdown. To be figured out as part of - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 Envoy::Api::External::registerApi(std::string(envoy_event_tracker_api_name), &event_tracker_); } diff --git a/library/common/engine_common.cc b/library/common/engine_common.cc index 576a8169e8..b20b31f147 100644 --- a/library/common/engine_common.cc +++ b/library/common/engine_common.cc @@ -14,9 +14,9 @@ EngineCommon::EngineCommon(int argc, const char* const* argv) // not_ listen for termination signals such as SIGTERM, SIGINT, etc // (https://github.com/envoyproxy/envoy/blob/048f4231310fbbead0cbe03d43ffb4307fff0517/source/server/server.cc#L519). // Previous crashes in iOS were experienced due to early event loop exit as described in - // https://github.com/lyft/envoy-mobile/issues/831. Ignoring termination signals makes it more - // likely that the event loop will only exit due to Engine destruction - // https://github.com/lyft/envoy-mobile/blob/a72a51e64543882ea05fba3c76178b5784d39cdc/library/common/engine.cc#L105. + // https://github.com/envoyproxy/envoy-mobile/issues/831. Ignoring termination signals makes it + // more likely that the event loop will only exit due to Engine destruction + // https://github.com/envoyproxy/envoy-mobile/blob/a72a51e64543882ea05fba3c76178b5784d39cdc/library/common/engine.cc#L105. options_.setSignalHandling(false); } diff --git a/library/common/engine_handle.cc b/library/common/engine_handle.cc index 6097054544..8cccdce1b9 100644 --- a/library/common/engine_handle.cc +++ b/library/common/engine_handle.cc @@ -17,7 +17,7 @@ envoy_status_t EngineHandle::runOnEngineDispatcher(envoy_engine_t, envoy_engine_t EngineHandle::initEngine(envoy_engine_callbacks callbacks, envoy_logger logger, envoy_event_tracker event_tracker) { // TODO(goaway): return new handle once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 strong_engine_ = std::make_shared(callbacks, logger, event_tracker); engine_ = strong_engine_; return 1; @@ -25,7 +25,7 @@ envoy_engine_t EngineHandle::initEngine(envoy_engine_callbacks callbacks, envoy_ envoy_status_t EngineHandle::runEngine(envoy_engine_t, const char* config, const char* log_level) { // This will change once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 if (auto e = engine()) { e->run(config, log_level); return ENVOY_SUCCESS; diff --git a/library/common/extensions/filters/http/platform_bridge/filter.cc b/library/common/extensions/filters/http/platform_bridge/filter.cc index 19cdba7d17..51c17da245 100644 --- a/library/common/extensions/filters/http/platform_bridge/filter.cc +++ b/library/common/extensions/filters/http/platform_bridge/filter.cc @@ -535,7 +535,7 @@ void PlatformBridgeFilter::resumeDecoding() { // 1) adding support to Envoy for (optionally) retaining the dispatcher, or // 2) retaining the engine to transitively retain the dispatcher via Envoy's ownership graph, or // 3) dispatching via a safe intermediary - // Relevant: https://github.com/lyft/envoy-mobile/issues/332 + // Relevant: https://github.com/envoyproxy/envoy-mobile/issues/332 dispatcher_.post([weak_self]() -> void { if (auto self = weak_self.lock()) { // Delegate to base implementation for request and response path. diff --git a/library/common/http/client.cc b/library/common/http/client.cc index 5bba847be6..123717116d 100644 --- a/library/common/http/client.cc +++ b/library/common/http/client.cc @@ -446,7 +446,7 @@ void Client::sendHeaders(envoy_stream_t stream, envoy_headers headers, bool end_ // TODO: handle potential race condition with cancellation or failure get a stream in the // first place. Additionally it is possible to get a nullptr due to bogus envoy_stream_t // from the caller. - // https://github.com/lyft/envoy-mobile/issues/301 + // https://github.com/envoyproxy/envoy-mobile/issues/301 if (direct_stream) { ScopeTrackerScopeState scope(direct_stream.get(), scopeTracker()); RequestHeaderMapPtr internal_headers = Utility::toRequestHeaders(headers); @@ -493,7 +493,7 @@ void Client::sendData(envoy_stream_t stream, envoy_data data, bool end_stream) { // TODO: handle potential race condition with cancellation or failure get a stream in the // first place. Additionally it is possible to get a nullptr due to bogus envoy_stream_t // from the caller. - // https://github.com/lyft/envoy-mobile/issues/301 + // https://github.com/envoyproxy/envoy-mobile/issues/301 if (direct_stream) { ScopeTrackerScopeState scope(direct_stream.get(), scopeTracker()); // The buffer is moved internally, in a synchronous fashion, so we don't need the lifetime @@ -531,7 +531,7 @@ void Client::sendTrailers(envoy_stream_t stream, envoy_headers trailers) { // TODO: handle potential race condition with cancellation or failure get a stream in the // first place. Additionally it is possible to get a nullptr due to bogus envoy_stream_t // from the caller. - // https://github.com/lyft/envoy-mobile/issues/301 + // https://github.com/envoyproxy/envoy-mobile/issues/301 if (direct_stream) { ScopeTrackerScopeState scope(direct_stream.get(), scopeTracker()); RequestTrailerMapPtr internal_trailers = Utility::toRequestTrailers(trailers); diff --git a/library/common/jni/jni_interface.cc b/library/common/jni/jni_interface.cc index c036ebf78e..bba603c72b 100644 --- a/library/common/jni/jni_interface.cc +++ b/library/common/jni/jni_interface.cc @@ -39,7 +39,7 @@ static void jvm_on_engine_running(void* context) { env->DeleteLocalRef(jcls_JvmonEngineRunningContext); // TODO(goaway): This isn't re-used by other engine callbacks, so it's safe to delete here. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332 + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332 env->DeleteGlobalRef(j_context); } @@ -105,7 +105,7 @@ extern "C" JNIEXPORT jlong JNICALL Java_io_envoyproxy_envoymobile_engine_JniLibr envoy_event_tracker event_tracker = {nullptr, nullptr}; if (j_event_tracker != nullptr) { // TODO(goaway): The retained_context leaks, but it's tied to the life of the engine. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332. + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332. jobject retained_context = env->NewGlobalRef(j_event_tracker); jni_log_fmt("[Envoy]", "retained_context: %p", retained_context); event_tracker.track = jvm_on_track; @@ -868,7 +868,7 @@ Java_io_envoyproxy_envoymobile_engine_JniLibrary_registerFilterFactory(JNIEnv* e jobject j_context) { // TODO(goaway): Everything here leaks, but it's all be tied to the life of the engine. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332 + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332 jni_log("[Envoy]", "registerFilterFactory"); jni_log_fmt("[Envoy]", "j_context: %p", j_context); jobject retained_context = env->NewGlobalRef(j_context); @@ -998,7 +998,7 @@ Java_io_envoyproxy_envoymobile_engine_JniLibrary_registerStringAccessor(JNIEnv* jobject j_context) { // TODO(goaway): The retained_context leaks, but it's tied to the life of the engine. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332. + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332. jobject retained_context = env->NewGlobalRef(j_context); envoy_string_accessor* string_accessor = diff --git a/library/common/main_interface.cc b/library/common/main_interface.cc index 025996897b..6c64062400 100644 --- a/library/common/main_interface.cc +++ b/library/common/main_interface.cc @@ -74,7 +74,7 @@ envoy_status_t set_preferred_network(envoy_network_t network) { envoy_status_t record_counter_inc(envoy_engine_t e, const char* elements, envoy_stats_tags tags, uint64_t count) { // TODO: use specific engine once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 return Envoy::EngineHandle::runOnEngineDispatcher( e, [name = std::string(elements), tags, count](auto& engine) -> void { engine.recordCounterInc(name, tags, count); @@ -84,7 +84,7 @@ envoy_status_t record_counter_inc(envoy_engine_t e, const char* elements, envoy_ envoy_status_t record_gauge_set(envoy_engine_t e, const char* elements, envoy_stats_tags tags, uint64_t value) { // TODO: use specific engine once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 return Envoy::EngineHandle::runOnEngineDispatcher( e, [name = std::string(elements), tags, value](auto& engine) -> void { engine.recordGaugeSet(name, tags, value); @@ -94,7 +94,7 @@ envoy_status_t record_gauge_set(envoy_engine_t e, const char* elements, envoy_st envoy_status_t record_gauge_add(envoy_engine_t e, const char* elements, envoy_stats_tags tags, uint64_t amount) { // TODO: use specific engine once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 return Envoy::EngineHandle::runOnEngineDispatcher( e, [name = std::string(elements), tags, amount](auto& engine) -> void { engine.recordGaugeAdd(name, tags, amount); @@ -104,7 +104,7 @@ envoy_status_t record_gauge_add(envoy_engine_t e, const char* elements, envoy_st envoy_status_t record_gauge_sub(envoy_engine_t e, const char* elements, envoy_stats_tags tags, uint64_t amount) { // TODO: use specific engine once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 return Envoy::EngineHandle::runOnEngineDispatcher( e, [name = std::string(elements), tags, amount](auto& engine) -> void { engine.recordGaugeSub(name, tags, amount); @@ -114,7 +114,7 @@ envoy_status_t record_gauge_sub(envoy_engine_t e, const char* elements, envoy_st envoy_status_t record_histogram_value(envoy_engine_t e, const char* elements, envoy_stats_tags tags, uint64_t value, envoy_histogram_stat_unit_t unit_measure) { // TODO: use specific engine once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 return Envoy::EngineHandle::runOnEngineDispatcher( e, [name = std::string(elements), tags, value, unit_measure](auto& engine) -> void { engine.recordHistogramValue(name, tags, value, unit_measure); @@ -197,7 +197,7 @@ void terminate_engine(envoy_engine_t engine) { Envoy::EngineHandle::terminateEng envoy_status_t drain_connections(envoy_engine_t e) { // This will change once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 return Envoy::EngineHandle::runOnEngineDispatcher( e, [](auto& engine) { engine.drainConnections(); }); } diff --git a/library/kotlin/io/envoyproxy/envoymobile/grpc/GRPCStreamPrototype.kt b/library/kotlin/io/envoyproxy/envoymobile/grpc/GRPCStreamPrototype.kt index 78618658af..6192c7d4d3 100644 --- a/library/kotlin/io/envoyproxy/envoymobile/grpc/GRPCStreamPrototype.kt +++ b/library/kotlin/io/envoyproxy/envoymobile/grpc/GRPCStreamPrototype.kt @@ -151,7 +151,7 @@ private class GRPCMessageProcessor { } val compressionFlag = byteArray[0] - // TODO: Support gRPC compression https://github.com/lyft/envoy-mobile/issues/501. + // TODO: Support gRPC compression https://github.com/envoyproxy/envoy-mobile/issues/501. if (compressionFlag.compareTo(0) != 0) { bufferedStream.reset() } diff --git a/library/objective-c/EnvoyBridgeUtility.h b/library/objective-c/EnvoyBridgeUtility.h index 1cb3429528..9eaa9d746e 100644 --- a/library/objective-c/EnvoyBridgeUtility.h +++ b/library/objective-c/EnvoyBridgeUtility.h @@ -86,7 +86,7 @@ static inline envoy_stats_tags toNativeStatsTags(EnvoyTags *tags) { static inline NSData *to_ios_data(envoy_data data) { // TODO: we are copying from envoy_data to NSData. - // https://github.com/lyft/envoy-mobile/issues/398 + // https://github.com/envoyproxy/envoy-mobile/issues/398 NSData *platformData = [NSData dataWithBytes:(void *)data.bytes length:data.length]; release_envoy_data(data); return platformData; diff --git a/library/objective-c/EnvoyEngineImpl.m b/library/objective-c/EnvoyEngineImpl.m index 0314c9badd..b0b725f9f0 100644 --- a/library/objective-c/EnvoyEngineImpl.m +++ b/library/objective-c/EnvoyEngineImpl.m @@ -412,7 +412,7 @@ - (instancetype)initWithRunningCallback:(nullable void (^)())onEngineRunning } // TODO(Augustyniak): Everything here leaks, but it's all tied to the life of the engine. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332. + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332. envoy_event_tracker native_event_tracker = {NULL, NULL}; if (eventTracker) { EnvoyEventTracker *objcEventTracker = @@ -444,7 +444,7 @@ - (void)dealloc { - (int)registerFilterFactory:(EnvoyHTTPFilterFactory *)filterFactory { // TODO(goaway): Everything here leaks, but it's all be tied to the life of the engine. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332 + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332 envoy_http_filter *api = safe_malloc(sizeof(envoy_http_filter)); api->init_filter = ios_http_filter_init; api->on_request_headers = ios_http_filter_on_request_headers; @@ -469,7 +469,7 @@ - (int)registerFilterFactory:(EnvoyHTTPFilterFactory *)filterFactory { - (int)registerStringAccessor:(NSString *)name accessor:(EnvoyStringAccessor *)accessor { // TODO(goaway): Everything here leaks, but it's all tied to the life of the engine. - // This will need to be updated for https://github.com/lyft/envoy-mobile/issues/332 + // This will need to be updated for https://github.com/envoyproxy/envoy-mobile/issues/332 envoy_string_accessor *accessorStruct = safe_malloc(sizeof(envoy_string_accessor)); accessorStruct->get_string = ios_get_string; accessorStruct->context = CFBridgingRetain(accessor); @@ -581,7 +581,7 @@ - (void)drainConnections { #pragma mark - Private - (void)startObservingLifecycleNotifications { - // re-enable lifecycle-based stat flushing when https://github.com/lyft/envoy-mobile/issues/748 + // re-enable lifecycle-based stat flushing when https://github.com/envoyproxy/envoy-mobile/issues/748 // gets fixed. NSNotificationCenter *notificationCenter = [NSNotificationCenter defaultCenter]; [notificationCenter addObserver:self diff --git a/library/swift/EngineBuilder.swift b/library/swift/EngineBuilder.swift index 8dadbf3291..be21401cbc 100644 --- a/library/swift/EngineBuilder.swift +++ b/library/swift/EngineBuilder.swift @@ -398,7 +398,7 @@ open class EngineBuilder: NSObject { /// Add a specific implementation of `EnvoyEngine` to use for starting Envoy. /// A new instance of this engine will be created when `build()` is called. /// Used for testing, as initializing with `EnvoyEngine.Type` results in a - /// segfault: https://github.com/lyft/envoy-mobile/issues/334 + /// segfault: https://github.com/envoyproxy/envoy-mobile/issues/334 @discardableResult func addEngineType(_ engineType: EnvoyEngine.Type) -> Self { self.engineType = engineType diff --git a/library/swift/grpc/GRPCStreamPrototype.swift b/library/swift/grpc/GRPCStreamPrototype.swift index f4e1e3b2ed..c69c1234a1 100644 --- a/library/swift/grpc/GRPCStreamPrototype.swift +++ b/library/swift/grpc/GRPCStreamPrototype.swift @@ -135,7 +135,7 @@ private enum GRPCMessageProcessor { } guard compressionFlag == 0 else { - // TODO: Support gRPC compression https://github.com/lyft/envoy-mobile/issues/501 + // TODO: Support gRPC compression https://github.com/envoyproxy/envoy-mobile/issues/501 buffer.removeAll() state = .expectingCompressionFlag return diff --git a/test/common/main_interface_test.cc b/test/common/main_interface_test.cc index 474a080a36..909b0dfe63 100644 --- a/test/common/main_interface_test.cc +++ b/test/common/main_interface_test.cc @@ -329,7 +329,7 @@ TEST(MainInterfaceTest, RegisterPlatformApi) { TEST(MainInterfaceTest, InitEngineReturns1) { // TODO(goaway): return new handle once multiple engine support is in place. - // https://github.com/lyft/envoy-mobile/issues/332 + // https://github.com/envoyproxy/envoy-mobile/issues/332 engine_test_context test_context{}; envoy_engine_callbacks engine_cbs{[](void* context) -> void { auto* engine_running = diff --git a/test/swift/integration/README.md b/test/swift/integration/README.md index 4b46a271ad..140a87444e 100644 --- a/test/swift/integration/README.md +++ b/test/swift/integration/README.md @@ -5,7 +5,7 @@ side via the ` setOnResponse{...}` functions. TODO: These tests are broken apart into different suites and bazel targets in order to tear down app state -- and thus static lifetime objects like the Envoy engine -- between tests. When -multiple engine support (https://github.com/lyft/envoy-mobile/issues/332) lands, all of these +multiple engine support (https://github.com/envoyproxy/envoy-mobile/issues/332) lands, all of these tests can be collapsed to the same suite/target. TODO: setOnTrailers is not tested as the neither the `direct_response` pathway, nor the router