engine: add H2 ping config API #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2021 18:42
junr03
commented
Aug 31, 2021
library/java/io/envoyproxy/envoymobile/engine/EnvoyConfiguration.java
Outdated
Show resolved
Hide resolved
goaway
reviewed
Aug 31, 2021
goaway
reviewed
Aug 31, 2021
added 5 commits
September 1, 2021 16:17
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
goaway
reviewed
Sep 2, 2021
goaway
reviewed
Sep 2, 2021
goaway
reviewed
Sep 2, 2021
goaway
reviewed
Sep 2, 2021
goaway
reviewed
Sep 2, 2021
|
Other than some nits about the defaults, I think this looks good. An integration test would be amazing, but that doesn't need to be part of this PR. |
|
Also, suggest merging main, to make sure you've picked up the new RBE configs for CI. |
added 3 commits
September 2, 2021 15:07
goaway
approved these changes
Sep 3, 2021
|
Thanks @junr03! |
carloseltuerto
pushed a commit
to carloseltuerto/envoy-mobile
that referenced
this pull request
Sep 7, 2021
Description: adds engine builder and config plumbing to setup h2 ping support Risk Level: low - exposed API. Default config is no-op in Envoy Testing: added tests Docs Changes: pending Signed-off-by: Jose Nino <jnino@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: adds engine builder and config plumbing to setup h2 ping support
Risk Level: low - exposed API. Default config is no-op in Envoy
Testing: added tests
Docs Changes: pending if reviewers agree with API