Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: add bazelw wrapper #1935

Merged
merged 1 commit into from
Dec 1, 2021
Merged

bazel: add bazelw wrapper #1935

merged 1 commit into from
Dec 1, 2021

Conversation

keith
Copy link
Member

@keith keith commented Nov 10, 2021

This wrapper allows developers to quickly get off the ground without
having to install bazel or bazelisk manually.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

bazelw Show resolved Hide resolved
@jpsim
Copy link
Contributor

jpsim commented Nov 10, 2021

Script itself looks good. We'd also need to update scripts and docs.

jingwei99
jingwei99 previously approved these changes Nov 10, 2021
Copy link
Contributor

@jingwei99 jingwei99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Keith!

now we just need to scriptify all other 1000 environment setups too (ok there are less than 1000 😂)

@keith
Copy link
Member Author

keith commented Nov 11, 2021

Updated to use for all CI scripts, I don't see public facing docs here that need updating

@keith keith marked this pull request as ready for review November 11, 2021 20:22
@jpsim
Copy link
Contributor

jpsim commented Nov 11, 2021

I don't see public facing docs here that need updating

I think we can replace the usage of bazelisk with ./bazelw here and in other files in docs/

@keith keith force-pushed the ks/bazel-add-bazelw-wrapper branch from 822d936 to d977adf Compare November 12, 2021 20:54
This wrapper allows developers to quickly get off the ground without
having to install bazel or bazelisk manually.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Copy link

@buildbreaker buildbreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keith !

@buildbreaker buildbreaker merged commit 5f1c5cc into main Dec 1, 2021
@buildbreaker buildbreaker deleted the ks/bazel-add-bazelw-wrapper branch December 1, 2021 18:24
3. Apply local hacks to make IntelliJ work using the branch `hack-for-intellij <https://github.com/lyft/envoy-mobile/tree/hack-for-intellij>`_
4. Open up the Envoy Mobile project using the Bazel import project wizard
1. Download a supported `IntelliJ version <https://www.jetbrains.com/idea/download/other.html>`_ supported by the Bazel plugin
2. Apply local hacks to make IntelliJ work using the branch `hack-for-intellij <https://github.com/lyft/envoy-mobile/tree/hack-for-intellij>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrong from before but the repo url is https://github.com/envoyproxy/envoy-mobile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

junr03 pushed a commit that referenced this pull request Dec 15, 2021
This wrapper allows developers to quickly get off the ground without
having to install bazel or bazelisk manually.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants