Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Envoy support per filter chain draining? #10899

Closed
shashankram opened this issue Apr 22, 2020 · 8 comments
Closed

Does Envoy support per filter chain draining? #10899

shashankram opened this issue Apr 22, 2020 · 8 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently

Comments

@shashankram
Copy link

My understanding has been that if a Listener with multiple filter chains is configured and a filter chain within the listener is updated, connections belonging to other filter chains but the same listener are also drained. Is this still the case?

Looking at a few PRs, I see that there has been some effort to support per filter chain draining:
#9205
#4540
#7246

Is this feature supported now?
What is the recommended listener configuration to drain connections per filter chain? Is a Filter Discovery Service (FDS) required?

@mattklein123 mattklein123 added the question Questions that are neither investigations, bugs, nor enhancements label Apr 22, 2020
@mattklein123
Copy link
Member

This is almost complete and should work transparently once #10662 lands (albeit in an alpha state). cc @lambdai

@shashankram
Copy link
Author

Thanks @mattklein123. To clarify, per filter chain draining would work without needing Filter Discovery Service - using a listener with multiple filter chains would transparently drain connections per filter chain?

@stale
Copy link

stale bot commented May 22, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 22, 2020
@shashankram
Copy link
Author

@lambdai is there an update on this?

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 27, 2020
@stale
Copy link

stale bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 26, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Jul 3, 2020
@shashankram
Copy link
Author

Checking again.

@vorishirne
Copy link

@shashankram I beleive filter chain draining is fixed. I read in some other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions that are neither investigations, bugs, nor enhancements stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants