Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event emission: implement generic event reporting gRPC client #10966

Open
junr03 opened this issue Apr 27, 2020 · 1 comment
Open

event emission: implement generic event reporting gRPC client #10966

junr03 opened this issue Apr 27, 2020 · 1 comment
Labels
area/observability area/service discovery design proposal Needs design doc/proposal before implementation help wanted Needs help!

Comments

@junr03
Copy link
Member

junr03 commented Apr 27, 2020

#10407 added proto definitions for a generic event reporting service. This issue tracks implementation details.

  1. Using a bidi stream where Envoy updates the emission stream based on responses from the sink gRPC service allows for in-band flexibility. Both for:
  • The types of events that Envoy emits, e.g, filter to only health check events.
  • The shape of the events emitted, e.g, configure the metrics events to report counters as deltas.
  1. The base implementation should account for generic logic, such as:
  • Stream establishment, and callbacks for custom logic over messages in the stream
  • Handling versioning of in-band config updates so that the server-side gRPC service is aware of the configuration of the data stream -- useful when the shape of the data can change via in-band config updates.

Relates to #8970 and #10968

@junr03
Copy link
Member Author

junr03 commented Apr 27, 2020

cc @baranov1ch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability area/service discovery design proposal Needs design doc/proposal before implementation help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

1 participant