Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP] Refactor protocol constraints checks #12279

Closed
yanavlasov opened this issue Jul 24, 2020 · 2 comments
Closed

[HTTP] Refactor protocol constraints checks #12279

yanavlasov opened this issue Jul 24, 2020 · 2 comments
Assignees
Labels
area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@yanavlasov
Copy link
Contributor

Protocol constraints checks consists of limits of inbound and outbound frames of different types. The implementation is spread out through the codec source code. For readability and sharing between legacy and new codec implementations, protocol constrains checks should be refactored into a dedicated class.

Sub-task of the #12278

@yanavlasov yanavlasov self-assigned this Jul 24, 2020
@yanavlasov yanavlasov added area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue labels Jul 24, 2020
@mattklein123
Copy link
Member

@yanavlasov is this a dup of #10646 or related?

@yanavlasov
Copy link
Contributor Author

I'd say it is a pre-requisite. This bug is to refactor flood checks, but the class can be extended to do other checks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

2 participants