Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails when thrift proxy extensions are disabled #12696

Closed
roelfdutoit opened this issue Aug 18, 2020 · 2 comments · Fixed by #12697
Closed

Build fails when thrift proxy extensions are disabled #12696

roelfdutoit opened this issue Aug 18, 2020 · 2 comments · Fixed by #12697

Comments

@roelfdutoit
Copy link
Contributor

The following build command fails:
bazel test //test/extensions/filters/network/...

.. when the following extensions are disabled in source/extensions/extensions_build_config.bzl:
envoy.filters.network.thrift_proxy
envoy.filters.thrift.router
envoy.filters.thrift.ratelimit

Build failure:

ERROR: test/extensions/filters/network/thrift_proxy/filters/BUILD:11:14: no such target '//test/extensions/filters/network/thrift_proxy:mocks': target 'mocks' not declared in package 'test/extensions/filters/network/thrift_proxy' defined by test/extensions/filters/network/thrift_proxy/BUILD and referenced by '//test/extensions/filters/network/thrift_proxy/filters:pass_through_filter_test'
ERROR: Analysis of target '//test/extensions/filters/network/thrift_proxy/filters:pass_through_filter_test' failed; build aborted: Analysis failed

I believe it is because the target in test/extensions/filters/network/thrift_proxy/filters/BUILD uses envoy_cc_test instead of envoy_extension_cc_test

@roelfdutoit
Copy link
Contributor Author

The build command above succeeds with my local changes. I will submit a PR

@roelfdutoit
Copy link
Contributor Author

@zuercher: This seems to be related to #12003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant