Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy.reloadable_features.consume_all_retry_headers deprecation #14639

Closed
mattklein123 opened this issue Jan 11, 2021 · 2 comments · Fixed by #14662
Closed

envoy.reloadable_features.consume_all_retry_headers deprecation #14639

mattklein123 opened this issue Jan 11, 2021 · 2 comments · Fixed by #14662
Assignees
@mattklein123
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.18.0

Comments

@mattklein123
Copy link
Member

Your change #11913 (router: consume all retry related headers) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
cc @numerodix
@mattklein123 mattklein123 added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jan 11, 2021
@mattklein123 mattklein123 self-assigned this Jan 11, 2021
@mattklein123 mattklein123 added this to the 1.18.0 milestone Jan 11, 2021
@numerodix
Copy link
Contributor

I'm happy to take this one.

@mattklein123
Copy link
Member Author

@numerodix please do, thanks!

@numerodix numerodix mentioned this issue Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattklein123 mattklein123

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

router: Remove envoy.reloadable_features.consume_all_retry_headers numerodix/envoy
2 participants
@numerodix @mattklein123