Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash policy should look at all values of a header #15182

Closed
markdroth opened this issue Feb 24, 2021 · 1 comment · Fixed by #15486
Closed

hash policy should look at all values of a header #15182

markdroth opened this issue Feb 24, 2021 · 1 comment · Fixed by #15486
Labels

Comments

@markdroth
Copy link
Contributor

The current hash policy code only looks at the first value of a given header. The code even has a TODO about this:

// TODO(mattklein123): Potentially hash on all headers.

For consistency with the changes that were recently made in routing to always look at multiple values of a given header, I think we should do the same thing here.

CC @htuch

@markdroth markdroth added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 24, 2021
@htuch
Copy link
Member

htuch commented Feb 25, 2021

Yeah, this seems a bug to me, we should hash on the full header as per @mattklein123

@mattklein123 mattklein123 added area/http help wanted Needs help! and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants