Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge the buffer parameter and op, or not #15218

Closed
lambdai opened this issue Feb 26, 2021 · 4 comments
Closed

Converge the buffer parameter and op, or not #15218

lambdai opened this issue Feb 26, 2021 · 4 comments
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@lambdai
Copy link
Contributor

lambdai commented Feb 26, 2021

Userspace Io Handle is following the IoSocketHandle pattern right now.

  1. Respect the watermark.
  2. Reserve and read. The reserve is an op that computing the upper limit of a move.

This io handle is not used anywhere until a specialized listener and connection factory is landed.

Create this issue to explore after

  1. How to improve the reserve-and-read? Do we want to use the exact value in socket handle?
  2. Since the internal socket represents a hidden and extra chain node betweens the downstream socket and upstream socket, should we aim at downstreamsocket to upstream socket fairness, or os socket to internal socket fairness?

Once we understand it, the next step is to either unify the buffer parameters(remove duplication definition) or admit the exception at the internal userspace socket.

@lambdai lambdai added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 26, 2021
@lambdai
Copy link
Contributor Author

lambdai commented Feb 26, 2021

CC @ggreenway @antoniovicente

@antoniovicente
Copy link
Contributor

Motivating comment thread: #14917 (comment)

I think this relates to buffer move limits, amount of data that the filter pipeline can move in one go and connection write limits. I agree that we want a consistent framework for these things.

@alyssawilk alyssawilk removed the triage Issue requires triage label Mar 1, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 31, 2021
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants