Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify URL parsing with GoogleURL #15290

Open
asraa opened this issue Mar 3, 2021 · 1 comment
Open

Unify URL parsing with GoogleURL #15290

asraa opened this issue Mar 3, 2021 · 1 comment

Comments

@asraa
Copy link
Contributor

asraa commented Mar 3, 2021

Two concerns:

Envoy uses http_parser_url to split the URL into pieces.

We should replace this with GoogleURL, which does URL parsing (https://chromium.googlesource.com/chromium/src/+/master/url#parsing). See
https://chromium.googlesource.com/chromium/src/+/master/url/gurl.h#340

Related Issues:
#5155
#6588

Can we bring back #11670?

cc @derekargueta @dio @envoyproxy/security-team

@asraa asraa added enhancement Feature requests. Not bugs or questions. area/security area/http labels Mar 3, 2021
@dio
Copy link
Member

dio commented Mar 8, 2021

I think @yanavlasov has a relevant plan for this, I'll try to propose something, but it will be good to hear from Yan first :).

@mattklein123 mattklein123 added help wanted Needs help! and removed enhancement Feature requests. Not bugs or questions. labels Mar 8, 2021
@yanavlasov yanavlasov self-assigned this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants