Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_proc crash when using grpc initial_metadata and REQ/RESP headers on 1.18+ #18099

Closed
pgeler opened this issue Sep 13, 2021 · 4 comments
Closed
Labels
bug stale stalebot believes this issue/PR has not been touched recently

Comments

@pgeler
Copy link

pgeler commented Sep 13, 2021

Issue was originally submitted to envoy-security, but rejected from there confirming that it was reproducible, asking to create a ticket in github:

dynamic functions like %REQ()% or %RESP()% causing crash for v1.18/v1.19. On v1.17 passing without crash.
config snippet, does not require working service, was tested with simple http:

          http_filters:
          - name: extension-matcher
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.ext_proc.v3alpha.ExternalProcessor
              failure_mode_allow: true
              message_timeout: 5s
              processing_mode:
                request_header_mode: "SEND"
                response_header_mode: "SEND"
                request_body_mode: "NONE"
                response_body_mode: "NONE"
                request_trailer_mode: "SKIP"
                response_trailer_mode: "SKIP"
              grpc_service:
                envoy_grpc:
                  cluster_name: origin
                initial_metadata:
                - key: "x-request-id"
                  value: "%REQ(x-request-id)%"
          - name: envoy.filters.http.router


@pgeler pgeler added bug triage Issue requires triage labels Sep 13, 2021
@pgeler pgeler changed the title ext_proc crash when using grpc initial_metadata and REQ/RESP headers ext_proc crash when using grpc initial_metadata and REQ/RESP headers on 1.18+ Sep 14, 2021
@alyssawilk
Copy link
Contributor

cc @gbrail @snowp

@alyssawilk alyssawilk removed the triage Issue requires triage label Sep 20, 2021
@gbrail
Copy link
Contributor

gbrail commented Sep 20, 2021

It looks like the problem is that we don't pass the "StreamInfo" to the gRPC stream when starting to talk to the ext_proc server. That's pretty easy to fix, and harder to write an integration test for but I'll work on it. Thanks!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 20, 2021
@pgeler
Copy link
Author

pgeler commented Oct 20, 2021

issue solved in #18190

@pgeler pgeler closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants