Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterChainMatch: Add metadata match criteria #18856

Closed
tonya11en opened this issue Nov 2, 2021 · 4 comments
Closed

FilterChainMatch: Add metadata match criteria #18856

tonya11en opened this issue Nov 2, 2021 · 4 comments
Labels
area/listener area/metadata enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@tonya11en
Copy link
Member

Add connection metadata match criteria for filter chain matching.

I have a use-case involving tagging various tenant connections' dynamic metadata with some ID in a listener filter. I'd like to use that metadata as filter chain matching criteria. As far as I can tell, there's currently no way to influence filter chain matching via the dynamic metadata for a connection.

I see that #18685 is opened for custom matcher extensions, but in my opinion that is overkill for what I'm trying to do and others would benefit from this change.

If this sounds like a reasonable ask, I (or someone in my group) can submit a patch.

@tonya11en tonya11en added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 2, 2021
@asraa asraa added area/listener area/metadata and removed triage Issue requires triage labels Nov 2, 2021
@mattklein123
Copy link
Member

There is #18685 and also #3411.

I realize that we can quickly add this, but it's just going to make the existing problem worse. Are there any resources for reworking how this configuration is handled via both extensions as well as configurable ordering?

@tonya11en
Copy link
Member Author

@mattklein123 let me talk with some folks and see if I can get some resources allocated to do this the right way.

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 2, 2021
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/listener area/metadata enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants