Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: templated factory registrations inheritance #20324

Closed
zhxie opened this issue Mar 14, 2022 · 3 comments
Closed

registry: templated factory registrations inheritance #20324

zhxie opened this issue Mar 14, 2022 · 3 comments
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently tech debt

Comments

@zhxie
Copy link
Contributor

zhxie commented Mar 14, 2022

Title: registry: templated factory registrations inheritance

Description:
Currently, factory registrations for base class cannot be used by their derivations. For example, an input Input registered for BaseClass cannot be created from a factory of DerivedClass. We do not have any precedence for these interactions with the existing extension registries, so it will be better if we can come up with a good solution to support shared inputs.

Relevant Links:
#20116

@zhxie zhxie added the triage Issue requires triage label Mar 14, 2022
@ggreenway ggreenway added enhancement Feature requests. Not bugs or questions. tech debt and removed triage Issue requires triage labels Mar 14, 2022
@kyessenov
Copy link
Contributor

Another instance where factories might need to be smarter: custom tree matchers are specialized by DataType even though the matchers do not directly inspect the data. That means we have to register the same matcher for each possible DataType.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 15, 2022
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently tech debt
Projects
None yet
Development

No branches or pull requests

3 participants