Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake in IpVersionsAndStreaming/ShadowPolicyIntegrationTest.RequestMirrorPolicyWithShadowOnlyTimeout #26590

Closed
alyssawilk opened this issue Apr 6, 2023 · 9 comments
Assignees
Labels
area/test flakes stale stalebot believes this issue/PR has not been touched recently

Comments

@alyssawilk
Copy link
Contributor

normally I don't post from open PRs but I can't see how a file move is relevant to failure so I think this one's real

https://dev.azure.com/cncf/envoy/_build/results?buildId=133376&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=8a34f9ed-4946-5fcf-7cd6-99c93070884d

[2023-04-06 14:39:01.202][335900][critical][backtrace] [./source/server/backtrace.h:96] #10: Envoy::Http::Http2::ServerConnectionImpl::dispatch() [0x12ec0a4]
[2023-04-06 14:39:01.213][335900][critical][backtrace] [./source/server/backtrace.h:96] #11: Envoy::FakeHttpConnection::ReadFilter::onData() [0xab689c]
[2023-04-06 14:39:01.224][335900][critical][backtrace] [./source/server/backtrace.h:96] #12: Envoy::Network::FilterManagerImpl::onContinueReading() [0x156cc90]
[2023-04-06 14:39:01.234][335900][critical][backtrace] [./source/server/backtrace.h:96] #13: Envoy::Network::ConnectionImpl::onReadReady() [0x1566114]
[2023-04-06 14:39:01.245][335900][critical][backtrace] [./source/server/backtrace.h:96] #14: Envoy::Network::ConnectionImpl::onFileEvent() [0x1564210]
[2023-04-06 14:39:01.256][335900][critical][backtrace] [./source/server/backtrace.h:96] #15: std::1::function::func<>::operator()() [0x1552e5c]
[2023-04-06 14:39:01.266][335900][critical][backtrace] [./source/server/backtrace.h:96] #16: Envoy::Event::FileEventImpl::assignEvents()::$1::invoke() [0x1553f8c]
[2023-04-06 14:39:01.277][335900][critical][backtrace] [./source/server/backtrace.h:96] #17: event_process_active_single_queue [0x17e8f14]
[2023-04-06 14:39:01.287][335900][critical][backtrace] [./source/server/backtrace.h:96] #18: event_base_loop [0x17e77b4]
[2023-04-06 14:39:01.298][335900][critical][backtrace] [./source/server/backtrace.h:96] #19: Envoy::FakeUpstream::threadRoutine() [0xab370c]
[2023-04-06 14:39:01.309][335900][critical][backtrace] [./source/server/backtrace.h:96] #20: Envoy::Thread::ThreadImplPosix::ThreadImplPosix()::{lambda()#1}::invoke() [0x17e05e0]
[2023-04-06 14:39:01.309][335900][critical][backtrace] [./source/server/backtrace.h:96] #21: start_thread [0xffffac660624]
Http2::ConnectionImpl 0x490be4dd690, max_headers_kb
: 60, max_headers_count
: 100, per_stream_buffer_limit
: 268435456, allow_metadata
: 1, stream_error_on_invalid_http_messaging
: 0, is_outbound_flood_monitored_control_frame
: 0, dispatching
: 1, raised_goaway
: 0, pending_deferred_reset_streams
.size(): 0
&protocol_constraints
:
ProtocolConstraints 0x490be4dd700, outbound_frames
: 0, max_outbound_frames_: 10000, outbound_control_frames_: 0, max_outbound_control_frames_: 1000, consecutive_inbound_frames_with_empty_payload_: 0, max_consecutive_inbound_frames_with_empty_payload_: 1, opened_streams_: 1, inbound_priority_frames_: 0, max_inbound_priority_frames_per_stream_: 100, inbound_window_update_frames_: 1, outbound_data_frames_: 0, max_inbound_window_update_frames_per_data_frame_sent_: 10
Number of active streams: 0, current_stream_id_: 1 Dumping current stream:

@phlax
Copy link
Member

phlax commented Apr 27, 2023

hitting this on the 1.26 release branch

@phlax phlax added the backport/review Request to backport to stable releases label Apr 27, 2023
@paul-r-gall
Copy link
Contributor

This should have been fixed by #26605 -- is that PR included in the 1.26 branch? I don't know how to tell.

@phlax
Copy link
Member

phlax commented May 2, 2023

you can see on the commit that landed 4b730e4

it shows the tags that include it, with the caveat that it doesnt include backports - in this case its there

@paul-r-gall
Copy link
Contributor

@phlax what compilation tags should I be running with to get a repro? and what's the frequency you're seeing?

@phlax
Copy link
Member

phlax commented May 2, 2023

what compilation tags should I be running with to get a repro?

there are some docs here worth checking https://github.com/envoyproxy/envoy/blob/1b906296c2525e9898b9880f0b6be0ed52003b17/test/integration/README.md#deflaking-tests

what's the frequency you're seeing?

not high altho, i think there was at least one on postsubmit today

https://dev.azure.com/cncf/envoy/_build/results?buildId=135895&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=67a76341-37f4-5b49-db38-acbb8a59af82&l=954

@paul-r-gall
Copy link
Contributor

The failure you linked above is IpVersionsAndStreaming/ShadowPolicyIntegrationTest.Basic/IPv6_streaming_shadow, not RequestMirrorPolicyWithShadowOnlyTimeout. It ought to be fixed by #27126.

@phlax
Copy link
Member

phlax commented May 2, 2023

thanks

ill test backporting it tomorrow

unfortunately i didnt post the link when i hit it on the 1.26 branch and i think it was in presubmit/pr so harder to find, so not sure exactly the error there

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 2, 2023
@phlax
Copy link
Member

phlax commented Jun 2, 2023

closing this - i have backported whatever would pick easily and im not seeing this issue on main or release branches

@phlax phlax closed this as completed Jun 2, 2023
@phlax phlax removed the backport/review Request to backport to stable releases label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test flakes stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants