Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downstreamRemoteAddress() method to Lua filter stream info object API #29738

Closed
kenjenkins opened this issue Sep 20, 2023 · 0 comments · Fixed by #29755
Closed

Add downstreamRemoteAddress() method to Lua filter stream info object API #29738

kenjenkins opened this issue Sep 20, 2023 · 0 comments · Fixed by #29755
Labels
enhancement Feature requests. Not bugs or questions. triage Issue requires triage

Comments

@kenjenkins
Copy link
Contributor

Title: Add downstreamRemoteAddress() method to Lua filter stream info object API

Description:
The Lua filter stream info object API currently provides access to the local address and the downstream direct remote address, but not the downstream remote address. (The main difference being that the "downstream remote address" takes into account the xff_num_trusted_hops setting, while the "downstream direct remote address" does not.)

Could we add a downstreamRemoteAddress() method to this API?

Relevant Links:

The downstreamDirectRemoteAddress() API method appears to have been added in #13536.

Documentation reference for the current Lua filter stream info object API: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/lua_filter#stream-info-object-api

@kenjenkins kenjenkins added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. triage Issue requires triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant