Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2 filter: supports forwarding ID tokens to upstream web service via the Authorization header bearer scheme #32805

Closed
zhaohuabing opened this issue Mar 10, 2024 · 8 comments
Labels
area/oauth enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@zhaohuabing
Copy link
Member

Title: OAuth2 filter: supports forwarding ID tokens to upstream web service via the Authorization header bearer scheme

Description:
OAuth2 filter has a forward_bearer_token configuration knob. If enabled, it forwards access tokens to the upstream web service via the Authorization header bearer scheme. Could we also add a knob to forward ID tokens via the Authorization header? This would allow the JWT filter or applications to utilize ID tokens for JWT-based authentication or other authorization purposes.

Related discussion in Envoy Gateway: envoyproxy/gateway#2425 (comment)

@zhaohuabing zhaohuabing added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Mar 10, 2024
@nezdolik nezdolik added area/oauth and removed triage Issue requires triage labels Mar 11, 2024
@nezdolik
Copy link
Member

@zvlb
Copy link
Contributor

zvlb commented Mar 25, 2024

I think this issue can help me with my case.

I want save Authorization Header from request. But if forward_bearer_token=false Authorization Header deleted from requests(

@evilr00t
Copy link

evilr00t commented Apr 4, 2024

👀 Hi guys, any update on this one?

Copy link

github-actions bot commented May 4, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 4, 2024
@derekargueta
Copy link
Member

@nezdolik can we nostale this? On my radar, wrapping up #2098 first

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label May 6, 2024
@michaelsauter
Copy link
Contributor

How does this relate to forward_payload_header of the Jwt Authentication filter? We use that to forward the ID token payload to the upstream (via another header than Authorization). In that case, the token is verified by envoy before sending it on. If the oauth filter would forward the ID token via the Authorization, it would not be able to verify it, because the oauth filter doesn't know e.g. the JWKS URI. I think it might be odd if the behaviour between the filters differs drastically in terms of provided security?

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 12, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oauth enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

6 participants