Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//test/integration:tcp_tunneling_integration_test flakes after custom inline header changes #34644

Closed
alyssawilk opened this issue Jun 10, 2024 · 0 comments · Fixed by #34652
Closed
Assignees

Comments

@alyssawilk
Copy link
Contributor

no logs on CI because we hit the UI limit but looks like the changes to custom inline headers did something to tsan and I suspect it's the cause of the (logless) asan flakes on CI

git checkout ec19828
bazel test --config=remote --config=clang-tsan //test/integration:tcp_tunneling_integration_test --runs_per_test=3
Executed 1 out of 1 test: 1 test passes.

git checkout f4a9e23
bazel test --config=remote --config=clang-tsan //test/integration:tcp_tunneling_integration_test --runs_per_test=3
//test/integration:tcp_tunneling_integration_test FAILED in 25 out of 90 in 204.0s

WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call) (pid=18)
Write of size 8 at 0x7b440001c840 by main thread:
#0 Envoy::Http::HeaderMapImpl::~HeaderMapImpl() (tcp_tunneling_integration_test+0x3456a34)
#1 Envoy::Http::TypedHeaderMapImplEnvoy::Http::ResponseHeaderMap::~TypedHeaderMapImpl() (tcp_tunneling_integration_test+0x34f5c96)
#2 Envoy::Http::ResponseHeaderMapImpl::~ResponseHeaderMapImpl() (tcp_tunneling_integration_test+0x34e8285)
#3 std::__1::default_deleteEnvoy::Http::ResponseHeaderMapImpl::operator()(Envoy::Http::ResponseHeaderMapImpl*) const tcp_tunneling_integration_test.cc (tcp_tunneling_integration_test+0x34f7fc3)
#4 std::__1::__shared_ptr_pointer<Envoy::Http::ResponseHeaderMapImpl*, std::__1::default_deleteEnvoy::Http::ResponseHeaderMapImpl, std::__1::allocatorEnvoy::Http::ResponseHeaderMapImpl >::__on_zero_shared() (tcp_tunneling_integration_test+0x3a9285a)
#5 std::__1::__shared_weak_count::__release_shared() memory.cpp (tcp_tunneling_integration_test+0xacbe56d)
#6 Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool) (tcp_tunneling_integration_test+0x39f8794)
#7 Envoy::(anonymous namespace)::ProxyingConnectIntegrationTest_ProxyConnectWithIP_Test::TestBody() tcp_tunneling_integration_test.cc (tcp_tunneling_integration_test+0x33be593)
#8 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::)(), char const) (tcp_tunneling_integration_test+0xac5b517)
#9 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::)(), char const) (tcp_tunneling_integration_test+0xac408ca)
#10 testing::Test::Run() (tcp_tunneling_integration_test+0xac24098)
#11 testing::TestInfo::Run() (tcp_tunneling_integration_test+0xac24ed1)
#12 testing::TestSuite::Run() (tcp_tunneling_integration_test+0xac25a70)
#13 testing::internal::UnitTestImpl::RunAllTests() (tcp_tunneling_integration_test+0xac35aaa)
#14 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::)(), char const) (tcp_tunneling_integration_test+0xac614b7)
#15 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::)(), char const) (tcp_tunneling_integration_test+0xac4418a)
#16 testing::UnitTest::Run() (tcp_tunneling_integration_test+0xac3536d)
#17 RUN_ALL_TESTS() (tcp_tunneling_integration_test+0x8431ca7)
#18 Envoy::TestRunner::runTests(int, char**) (tcp_tunneling_integration_test+0x8431000)
#19 main (tcp_tunneling_integration_test+0x842dd8e)

Previous read of size 8 at 0x7b440001c840 by thread T144:
#0 Envoy::Http::TypedHeaderMapImplEnvoy::Http::ResponseHeaderMap::getInline(Envoy::Http::CustomInlineHeaderRegistry::Handle<(Envoy::Http::CustomInlineHeaderRegistry::Type)2>) const (tcp_tunneling_integration_test+0x34e93f2)
#1 Envoy::Http::ResponseHeaderMapImpl::Status() const (tcp_tunneling_integration_test+0x34ed625)
#2 non-virtual thunk to Envoy::Http::ResponseHeaderMapImpl::Status() const (tcp_tunneling_integration_test+0x34f51c9)
#3 Envoy::Http::Http1::ResponseEncoderImpl::encodeHeaders(Envoy::Http::ResponseHeaderMap const&, bool) (tcp_tunneling_integration_test+0x758b81f)
#4 non-virtual thunk to Envoy::Http::Http1::ResponseEncoderImpl::encodeHeaders(Envoy::Http::ResponseHeaderMap const&, bool) (tcp_tunneling_integration_test+0x758c200)
#5 Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool)::$_2::operator()() const fake_upstream.cc (tcp_tunneling_integration_test+0x3a13eb6)
#6 decltype(static_cast<Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool)::$_2&>(fp)()) std::__1::__invoke<Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool)::$_2&>(Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool)::$_2&) fake_upstream.cc (tcp_tunneling_integration_test+0x3a13d25)
#7 void std::__1::__invoke_void_return_wrapper<void, true>::__call<Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool)::$_2&>(Envoy::FakeStream::encodeHeaders(Envoy::Http::HeaderMap const&, bool)::$_2&) fake_upstream.cc (tcp_tunneling_integration_test+0x3a13c9d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants