-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider using libdeflate instead of libzlib #5131
Comments
@gsagula WDYT? |
I don't know much about @mvrhov Did you benchmark it yourself? I couldn't find a comparison in there project, other than statements saying that it is faster. |
We haven't had time to test it yet. However for as is it more important in having smaller file size because we store a lot of xml and json data gzipped, that the browsers can still decompress than the speed. |
IMO, If performance is the reason for changing this library, we need to make sure that the replacement will produce better results before doing any work. WDYT? Another thing that we need to consider here is that Envoy, in order to reduce latency, it flushes on every data frame which sacrifices the compression a bit. It seems that for your use-case, the compression engine should be doing the opposite. |
I agree with what have you written. My answer might not have been clear enough. We store the gzipped files on disk and then ATM we configure the nginx to serve them as is. |
Thanks for elaborating it. I'm not sure that Envoy can serve static files yet. There is an open issue for that #378. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions. |
Issue Template
Title: libdeflate, faster zlib replacement
Description:
libdeflate is supposed to be a faster & offer better compression at the same level alternative to zlib, it also offers more compression levels, which is not necessary here, while retaining the decompression compatibility.
Unfortunately it's api is not compatible with the one from zlib
[optional Relevant Links:]
https://github.com/ebiggers/libdeflate
The text was updated successfully, but these errors were encountered: