Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis proxy: add access log #6138

Open
incfly opened this issue Mar 1, 2019 · 7 comments
Open

redis proxy: add access log #6138

incfly opened this issue Mar 1, 2019 · 7 comments
Labels
area/access_log enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@incfly
Copy link
Contributor

incfly commented Mar 1, 2019

Title: Access log not available for redis proxy filter

Description:
TCP proxy filter has access log which is useful for debugging. redis proxy however, does not have this field to configure. In a debugging senario, I have to changed to redis proxy to tcp proxy to verify traffic go through envoy.

[optional Relevant Links:]

I'm not so sure the appropriate way to debug the case above and if access log makes sense for networking filter or not. Please feel free to point something that's intended to be used instead.

@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Mar 1, 2019
@stale
Copy link

stale bot commented Mar 31, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 31, 2019
@stale
Copy link

stale bot commented Apr 7, 2019

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Apr 7, 2019
@tony612
Copy link
Contributor

tony612 commented Nov 26, 2019

Any progress on this? I thought Redis will have same access logs as TCP proxy.

@mattklein123 mattklein123 reopened this Nov 26, 2019
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Nov 26, 2019
@mattklein123 mattklein123 added help wanted Needs help! stale stalebot believes this issue/PR has not been touched recently labels Nov 26, 2019
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Nov 26, 2019
@mattklein123 mattklein123 changed the title Access log not available for redis proxy filter redis proxy: add access log Nov 26, 2019
@wbpcode
Copy link
Member

wbpcode commented Dec 11, 2020

See #13085
May be we need a universal design for all protocols.

@dio
Copy link
Member

dio commented Dec 11, 2020

@cpakulski thoughts?

@cpakulski
Copy link
Contributor

I am targeting this for release 1.18. Not sure about the final form yet. It may be totally flexible or maybe a class would have to derived from a base class. The final goal is to have access log common to various databases understood by Envoy filters: postgres, mysql, redis, mongo, etc.

@shanth96
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access_log enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

7 participants