Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named filter chains #7870

Closed
rshriram opened this issue Aug 8, 2019 · 5 comments · Fixed by #7966
Closed

named filter chains #7870

rshriram opened this issue Aug 8, 2019 · 5 comments · Fixed by #7966
Labels
api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue

Comments

@rshriram
Copy link
Member

rshriram commented Aug 8, 2019

It would be good from a stats perspective to have names for the filter chains so that users can easily see how many connections matched on a specific filter chain match [say by SNI or ips]. From a FCDS perspective, adding names is also helpful as we can now tender filterchain resources as named objects, spit out informative errors for specific filter chains, etc.

cc @silentdai ..

@rshriram
Copy link
Member Author

rshriram commented Aug 8, 2019

I think this has some relation to #7867 in that we need several objects in the API to be named. Even if we dont use the names immediately now, its still useful to ship with one so that we can start taking advantage of it over time.

@rshriram
Copy link
Member Author

rshriram commented Aug 8, 2019

cc @envoyproxy/api-shepherds

@mattklein123
Copy link
Member

I think this has some relation to #7867 in that we need several objects in the API to be named. Even if we dont use the names immediately now, its still useful to ship with one so that we can start taking advantage of it over time.

Yes this is top of mind for v3. We need to figure out a way to do this so that simple configs don't get bogged down but we give advanced configs flexibility. cc @htuch

@mattklein123 mattklein123 added api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue labels Aug 8, 2019
@rshriram
Copy link
Member Author

rshriram commented Aug 8, 2019

is it possible to add this to existing filterChains as it currently has no name field.

@lambdai
Copy link
Contributor

lambdai commented Aug 8, 2019

My 2 cents: we can add the name in current filter chain.
Soon the FCDS need the filter chain name anyway. By then the name uniqueness will be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v3 Major version release @ end of Q3 2019 no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants