-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
named filter chains #7870
Comments
I think this has some relation to #7867 in that we need several objects in the API to be named. Even if we dont use the names immediately now, its still useful to ship with one so that we can start taking advantage of it over time. |
cc @envoyproxy/api-shepherds |
Yes this is top of mind for v3. We need to figure out a way to do this so that simple configs don't get bogged down but we give advanced configs flexibility. cc @htuch |
is it possible to add this to existing filterChains as it currently has no name field. |
My 2 cents: we can add the name in current filter chain. |
It would be good from a stats perspective to have names for the filter chains so that users can easily see how many connections matched on a specific filter chain match [say by SNI or ips]. From a FCDS perspective, adding names is also helpful as we can now tender filterchain resources as named objects, spit out informative errors for specific filter chains, etc.
cc @silentdai ..
The text was updated successfully, but these errors were encountered: