[benchmark] ASSERT failure in //test/extensions/filters/network/redis_proxy:command_split_speed_test_test

[antoniovicente]

Description:
The redis_proxy:command_split_speed_test_test benchmark hits an ASSERT in extensions/filters/network/common/redis/codec.h when run in debug mode.

Repro steps:
bazel run -c dbg //test/extensions/filters/network/redis_proxy:command_split_speed_test

Logs:
BM_Split_Copy/64/131072 594388 ns 594386 ns 1124
BM_Split_Copy/100/131072 675364 ns 675320 ns 816
[2020-01-02 18:52:43.086][123603][critical][assert] [bazel-out/k8-dbg/bin/source/extensions/filters/network/common/redis/virtual_includes/codec_interface/extensions/filters/network/common/redis/codec.h:67] assert failure: end < base_array->asArray().size().

Call Stack:
Caught Aborted, suspect faulting address 0x14e380001e2d3
Backtrace (use tools/stack_decode.py to get line numbers):
Envoy version: 0821223bfed22a890dee853e6c84ce4d27befcf3/1.13.0-dev/Modified/DEBUG/BoringSSL
#0: Envoy::SignalAction::sigHandler() [0x1eed9bc]
#1: __restore_rt [0x7f411b24f3a0]
#2: Envoy::Extensions::NetworkFilters::Common::Redis::RespValue::RespValue() [0xc8629d]
#3: std::__1::__compressed_pair_elem<>::__compressed_pair_elem<>() [0xca2335]
#4: std::__1::__compressed_pair<>::__compressed_pair<>() [0xca1e86]
#5: std::__1::__shared_ptr_emplace<>::__shared_ptr_emplace<>() [0xca1ad5]
#6: std::__1::shared_ptr<>::make_shared<>() [0xca17f7]
#7: std::__1::make_shared<>() [0xca1685]
#8: Envoy::Extensions::NetworkFilters::RedisProxy::CommandSplitSpeedTest::createShared() [0xca1512]
#9: BM_Split_CreateShared() [0xc82acc]
#10: benchmark::internal::FunctionBenchmark::Run() [0x1fc5cd1]
#11: benchmark::internal::BenchmarkInstance::Run() [0x1fd814f]
#12: benchmark::internal::(anonymous namespace)::RunInThread() [0x1fd0631]
#13: benchmark::internal::(anonymous namespace)::BenchmarkRunner::DoNIterations() [0x1fcfe9c]
#14: benchmark::internal::(anonymous namespace)::BenchmarkRunner::DoOneRepetition() [0x1fcf78b]
#15: benchmark::internal::(anonymous namespace)::BenchmarkRunner::BenchmarkRunner() [0x1fcf54a]
#16: benchmark::internal::RunBenchmark() [0x1fcf216]
#17: benchmark::internal::(anonymous namespace)::RunBenchmarks() [0x1fbe3f8]
#18: benchmark::RunSpecifiedBenchmarks() [0x1fbdd49]
#19: benchmark::RunSpecifiedBenchmarks() [0x1fbd7a3]
#20: main [0x1eecf86]
#21: __libc_start_main [0x7f411aea152b]

[antoniovicente]

@HenryYYang

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.