From ff89c319bd190169d084405c475619a628ec42ff Mon Sep 17 00:00:00 2001 From: Ali Beyad Date: Wed, 27 Mar 2024 19:48:04 +0000 Subject: [PATCH 1/2] ci: Make the mobile-cc CI job run on all Envoy changes It's important for us to run the mobile C++ unit and integration tests on any Envoy change. If we don't, we run the risk of breaking Envoy Mobile with seemingly benign changes. For example, https://github.com/envoyproxy/envoy/pull/32775 caused Envoy Mobile to permafail because an Envoy Mobile unit test wasn't run (see https://github.com/envoyproxy/envoy/pull/33158 for the fix). This change ensures that the Envoy Mobile C++ tests run on all core Envoy changes. There aren't too many of these tests, so it shouldn't add much to the runtime of CI per PR. Signed-off-by: Ali Beyad --- .github/config.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/config.yml b/.github/config.yml index 18e83d891fee..6af3858645ea 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -208,14 +208,7 @@ run: - tools/code_format/check_format.py mobile-cc: paths: - - .bazelrc - - .bazelversion - - .github/config.yml - - bazel/external/quiche.BUILD - - bazel/repository_locations.bzl - - mobile/.bazelrc - - mobile/**/* - - tools/code_format/check_format.py + - "**/*" mobile-compile-time-cc: paths: - "**/*" From 6cbaf10ade78c602f806c02b1838213dad6914b5 Mon Sep 17 00:00:00 2001 From: Ali Beyad Date: Thu, 28 Mar 2024 04:43:03 +0000 Subject: [PATCH 2/2] phlax feedback Signed-off-by: Ali Beyad --- .github/config.yml | 45 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/.github/config.yml b/.github/config.yml index 6af3858645ea..846771e06a19 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -208,10 +208,36 @@ run: - tools/code_format/check_format.py mobile-cc: paths: - - "**/*" + - .bazelrc + - .bazelversion + - .github/config.yml + - api/**/* + - bazel/external/quiche.BUILD + - bazel/repository_locations.bzl + - envoy/**/* + - mobile/.bazelrc + - mobile/**/* + - source/**/* + - test/config/**/* + - test/integration/* + - test/mocks/**/* + - test/test_common/**/* mobile-compile-time-cc: paths: - - "**/*" + - .bazelrc + - .bazelversion + - .github/config.yml + - api/**/* + - bazel/external/quiche.BUILD + - bazel/repository_locations.bzl + - envoy/**/* + - mobile/.bazelrc + - mobile/**/* + - source/**/* + - test/config/**/* + - test/integration/* + - test/mocks/**/* + - test/test_common/**/* mobile-compile-time-options: paths: - .bazelrc @@ -234,9 +260,20 @@ run: - tools/code_format/check_format.py mobile-core: paths: - - "**/*" - - "*" + - .bazelrc + - .bazelversion + - .github/config.yml + - api/**/* + - bazel/external/quiche.BUILD + - bazel/repository_locations.bzl + - envoy/**/* - mobile/.bazelrc + - mobile/**/* + - source/**/* + - test/config/**/* + - test/integration/* + - test/mocks/**/* + - test/test_common/**/* mobile-format: paths: - .bazelrc