Initial Gateway API Conformance

[danehans]

The community has established Gateway API conformance as the target of the 0.0.2 release. This is a meta issue, in that issues, PRs, etc. that target this goal should be linked to this issue.

[danehans]

Since conformance tests are a moving target and being fully conformant may be a considerable undertaking, we should identify a subset of tests that are the v0.2.0 target.

xref: #11 (comment)
xref conformance tests: https://github.com/kubernetes-sigs/gateway-api/tree/master/conformance

@youngnick feel free to provide input.

[youngnick]

Yes, I think we should pick a Gateway API release as our first milestone target, we could choose either v0.4.3, the final v1alpha2 release, or the forthcoming v0.5.0, the first v1beta1 release. I'm inclined toward the latter.

[danehans]

@skasisom6 the v0.2.0 goal is for Envoy Gateway to pass Gateway API conformance tests. This means that Envoy Gateway will provide a set of core API Gateway functionality. When you have a moment, please review Gateway API conformance, along with the conformance tests to learn more about conformance. Let us know if these features are not consistent with your requirements for the release.

[danehans]

@skasisom6 the v0.2.0 goal is for Envoy Gateway to pass Gateway API conformance tests. This means that Envoy Gateway will provide a set of core API Gateway functionality. When you have a moment, please review Gateway API conformance, along with the conformance tests to learn more about conformance. Let us know if these features are not consistent with your requirements for the release.

[skriss]

I can work on getting the Gateway API conformance tests running in CI so as soon as we have something integrated, we can start running tests against it. I'll file a specific issue for it.

[danehans]

v0.2.0 will focus on httproute conformance, e.g. not tlsroute, tcproute, etc. @kflynn we should make sure the docs state this.

xref #17

[skriss]

Large blockers for getting Gateway API conformance tests to run:

• Set Gateway.Status.Addresses #330 (conformance uses the address in Gateway.Status.Addresses to send HTTP requests; we need to set this to the provisioned Service's external IP) (PR: Adds Support for Managing Gateway Status Addresses #352)
• Surface Gateway Ready status based on Envoy Deployment Status #345 (conformance tests won't proceed until a Gateway has a Condition of "Ready: true") (PR: Add Gateway condition based on Envoy deployment status #392)
• Gateway & HTTPRoute status computed by Gateway API translator needs to be written to API #329 (conformance is equally concerned with HTTP requests succeeding and Gateway API resources having the correct statuses; we need to be writing statuses to the apiserver)
• EG cannot collapse the base Gateways defined in the conformance tests #349 (EG's model is to merge all Gateways of a GatewayClass but the base conformance Gateways are not mergeable)

Specific "core" conformance features still to be implemented:

• add support for request redirect filter #159 (PR: Add support for redirect filters #249)
• add support for request header modifier filter #158 (PR: Add support for request modifier filters #363)
• return 500's for invalid HTTPRoute backend refs #162
• add support for TLSRoute / TLS listener protocol / TLS passthrough #168 (TLS passthrough with TLSRoute does look to be a core conformance feature, but there are not currently conformance tests for it) (PR: TLS Passthrough support #402)
• add ReferenceGrant controller #411

It's although worth noting that the Gateway API conformance tests are still a work in progress -- not every feature tagged as "core" in the API spec has tests yet, but they are being continually added. So -- we should try to get all the core features implemented, whether they currently have a conformance test or not, so we're not behind the ball when corresponding tests do get added.

[danehans]

Note that #168 and #411 are not required to pass conformance tests.

[danehans]

Outstanding v0.2.0 conformance test issues.

[danehans]

2 remaining referencegrant tests should pass when #588 is fixed.

[danehans]

Closing since all core conformance tests are passing. All but one RefernceGrant test (tracked by #539) is passing.