New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore nonce in request caching? #113

Open

jessicayuen opened this issue Jul 28, 2020 · 0 comments

Labels

component: cache

Member

jessicayuen commented Jul 28, 2020

Cache is in the format aggregated_key: {Response, Requests[]}

Request is a pointer to the entire request object, which means that subsequent (N)ACKs (which increments the nonce) are mutating the cache.

This is not breaking because we clean up prior requests, but there is room for optimization here to not constantly mutate the cache on (N)ACKs.

The text was updated successfully, but these errors were encountered:

jessicayuen added component: orchestrator component: cache and removed component: orchestrator labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment