Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong v51 release (Gnome 44) & versioning issue #302

Closed
pakaoraki opened this issue Oct 14, 2023 · 5 comments
Closed

Wrong v51 release (Gnome 44) & versioning issue #302

pakaoraki opened this issue Oct 14, 2023 · 5 comments

Comments

@pakaoraki
Copy link
Collaborator

After some investigation on #222, I figure out that the bug #285 is back for Gnome 44 (Fullscreen inhibit gets stuck due to a race condition) with the version v51 from gnome extension page.

In fact, the fix is missing and after a quick comparison, it's seams that's the code from gnome-shell-43-44 branch is not the one from the version v51 available.

I'm also a bit confuse about the mismatch between version in GitHub repository and gnome extension page:

  • for Gnome 45: v50 is v52.
  • for Gnome 44: v49 is v51.

The metadata.json file have been rewritten by a tool named SweetTooth: so I guess it's part of the release process but I'm not very familiar with it.

@eonpatapon : can you confirm the issue with v51 release please ?

@stuarthayhurst
Copy link
Collaborator

The metadata.json file have been rewritten by a tool named SweetTooth: so I guess it's part of the release process but I'm not very familiar with it.

Yea, the bundle gets unzipped, the metadata is rewritten by SweetTooth and then it's repacked. Regardless of the number you give as the version, SweetTooth will strip it out and replace it with the next numerical version, following on from the last uploaded release (including rejected uploads).

@pakaoraki
Copy link
Collaborator Author

Maybe we could match the github version number with the release ? what do you think ?

@stuarthayhurst
Copy link
Collaborator

Makes sense to do it. I had to do that to my extensions a few times in the past anyway.

@eonpatapon
Copy link
Owner

I'm trying to have the same versions, but it's not easy as when you upload to e.g.o it will not use the version defined in the metadata, it will just take the next integer of the previous upload. It's easy to mess things up when you re-upload, upload for an old version etc...

@stuarthayhurst
Copy link
Collaborator

Closing, as there's not much to do here, except syncing it at release time when things fall out of sync

@stuarthayhurst stuarthayhurst closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants