Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EasyRequestId] Add support for queue messages #650

Closed
natepage opened this issue Jul 9, 2021 · 2 comments
Closed

[EasyRequestId] Add support for queue messages #650

natepage opened this issue Jul 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@natepage
Copy link
Member

natepage commented Jul 9, 2021

The correlation id could be added to queue messages and then used when processing them so it's carried in async processed triggered by the original request.

@natepage natepage added the enhancement New feature or request label Jul 9, 2021
@natepage
Copy link
Member Author

natepage commented Jul 9, 2021

Having a look at the package it relies exclusively on the request, that's not a great design.
We will need to refactor it, instead of having a setRequest(Request $request) to have a setResolver(callable $resolver).

This way we can easily change the way the IDs are resolved:

  • from request
  • from symfony messenger envelope
  • from laravel queue job
  • etc.

@natepage
Copy link
Member Author

done in #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant