Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kv_database_config #763

Closed
heifner opened this issue Jul 18, 2022 · 3 comments
Closed

Remove kv_database_config #763

heifner opened this issue Jul 18, 2022 · 3 comments
Labels
OCI OCI working this issue...

Comments

@heifner
Copy link
Member

heifner commented Jul 18, 2022

Mandel does not use kv_database_config as it is part of Key-Value host functions not in Mandel. This should be removed. Removing it modifies chainbase schema, and snapshot version. May want to consider just marking it as not used and leaving it to avoid having to modify the chainbase schema and snapshot version.

@heifner heifner added the planning Propose change to milestone in next planning meeting label Jul 18, 2022
@matthewdarwin
Copy link

Or v7 snapshots here we come.... ;-)

@stephenpdeos
Copy link
Member

An acceptable short term solution for now will be inserting a comment in the header indicating this is not in use. This will be prioritized for snapshot v7.

@stephenpdeos stephenpdeos added OCI OCI working this issue... and removed planning Propose change to milestone in next planning meeting labels Jul 19, 2022
@ericpassmore ericpassmore transferred this issue from eosnetworkfoundation/mandel Aug 6, 2022
@ericpassmore ericpassmore transferred this issue from another repository Aug 6, 2022
@heifner
Copy link
Member Author

heifner commented Aug 23, 2022

Resolved by #753

@heifner heifner closed this as completed Aug 23, 2022
Repository owner moved this from Todo to Done in ENF Engineering Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue...
Projects
Status: Done
Development

No branches or pull requests

3 participants