Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove/skip appropriate steps in CI for forked repos #772

Closed
spoonincode opened this issue Jul 21, 2022 · 1 comment
Closed

remove/skip appropriate steps in CI for forked repos #772

spoonincode opened this issue Jul 21, 2022 · 1 comment
Labels
cicd Changes related to builds and CICD

Comments

@spoonincode
Copy link
Member

workflow runs initiated by PRs from forked repos do not have a GITHUB_TOKEN that can upload to ghcr among other things. Any steps that require that should be skipped so that PR can "go green".

At the moment this is the contract builder upload step. Any PRs coming from forks break on that step when realistically it could just be skipped.
@spoonincode spoonincode added the cicd Changes related to builds and CICD label Jul 21, 2022
@spoonincode spoonincode mentioned this issue Aug 6, 2022
Closed
@spoonincode spoonincode changed the title remove/skip apporpiate steps in CI for forked repos remove/skip appropriate steps in CI for forked repos Jul 22, 2022
@ericpassmore ericpassmore transferred this issue from eosnetworkfoundation/mandel Aug 6, 2022
@ericpassmore ericpassmore transferred this issue from another repository Aug 6, 2022
@spoonincode spoonincode moved this from Todo to Done in ENF Engineering Aug 29, 2022
@spoonincode
Copy link
Member Author

I'm considering this resolved as of AntelopeIO/leap#8 & AntelopeIO/leap#28. Builds from forks work fine unless they change a platform definition. However, changing a platform definition should be a rather rare event, even for forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cicd Changes related to builds and CICD
Projects
ENF Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spoonincode