Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve net_plugin syncing via communication of earliest available block #792

Closed
heifner opened this issue Aug 8, 2022 · 2 comments
Closed
Labels
planning Propose change to milestone in next planning meeting

Comments

@heifner
Copy link
Member

heifner commented Aug 8, 2022

Currently the net_plugin handshake message does not include earliest available block information which causes many requests from peers for blocks that a node does not have.

Include the earliest available block on a node in the handshake message. One potential way would be to look at the peers network_version after the initial handshake and send a handshake_v2 which includes the earliest block info. handshake_v2 could be detected according to network_version of the handshake to know if any additional information is included after the end of handshake_message. This additional information can't be sent until verification of the peer's version as an older version of net_plugin would not correctly handle the additional information after the handshake_message data.

@heifner heifner moved this to Todo in ENF Engineering Aug 8, 2022
@heifner heifner added the planning Propose change to milestone in next planning meeting label Aug 8, 2022
@stephenpdeos
Copy link
Member

This is work that may be made obsolete due to upcoming P2P work.

@heifner
Copy link
Member Author

heifner commented May 3, 2023

Subsumed by AntelopeIO/leap#1072

@heifner heifner closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in ENF Engineering May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planning Propose change to milestone in next planning meeting
Projects
Status: Done
Development

No branches or pull requests

2 participants