-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rolling deploy #664
rolling deploy #664
Conversation
8687fb8
to
cd4fc7a
Compare
11d5ba5
to
4877869
Compare
Closes #666 |
Could you document how things are working and how to maintain them when you're done? 🙏 |
a1f2718
to
0622a84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!!
I pushed a few commits to update the docs and added non-blocking comments and questions.
Regarding publishing to npm
- Could you add a quick readme to the npm packages? (@epfml/discojs, @epfml/discojs-web and @epfml/discojs-node)?
- I saw that discojs, discojs-node, discojs-web have been published, should we also publish the server (last published 1y ago) and the web-client (which used to be @epfml/discojs)?
Regarding Docker running ./with_server
fails with error
=> ERROR [builder 12/14] RUN npm --workspace=discojs --workspace=discojs 0.2s
------
> [builder 12/14] RUN npm --workspace=discojs --workspace=discojs-node run build:
0.155 npm ERR! No workspaces found:
0.155 npm ERR! --workspace=discojs --workspace=discojs-node
0.156
0.156 npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2024-05-08T09_21_38_612Z-debug-0.log
------
Dockerfile:14
--------------------
12 | COPY discojs-node/ discojs-node/
13 | COPY tsconfig.base.json .
14 | >>> RUN npm --workspace=discojs --workspace=discojs-node run build
15 |
16 | COPY server/ server/
--------------------
ERROR: failed to solve: process "/bin/sh -c npm --workspace=discojs --workspace=discojs-node run build" did not complete successfully: exit code: 1
It seems the same error occurred in the github actions I don't know what changed after your last commit
573dda3
to
379cf00
Compare
good idea, added in latest commit.
NPM is more for dependencies than end products, the server itself is published on github packages. I don't really see the need to publish the webapp itself.
it's now worked around with #672 |
429956d
to
01a05aa
Compare
I think there was a point where the goal was to let users deploy their own server and webapp (and the github pages were just to showcase Disco rather than actually be used), we should probably discuss this at the weekly to clarify how we want Disco to be used. |
8a433d5
to
6e816dc
Compare
Conclusion from the weekly, Disco users wanting to deploy their own Disco instance are not the priority because it is a minority of experts. We assume some technical knowledge and let them deploy their own server and webapp by cloning the repository and following the DEV.md instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!! Only non-blocking doc comments
It seems that some rebasing reverted some of the changes I pushed (like renaming deployement.md to deplyoment.md, renaming disc), could you check what got lost on the way if you have the time?
Closes: #621
d3bbd0e
to
58b6260
Compare
live @ https://discolab.ai